Zimbra Releases/8.6.0/P1/Changelog

Zimbra Collaboration 8.6.0 GA Release Patch 1 Changelog

Bug 85158
Impossible to create an external caldav calendar
Change 532483 by achhatre@achhatre_mac on 2014/12/22 04:10:15

	Bug: 85158, Bug: 82811 - Impossible to create an external caldav 
	calendar, Creating local calendar after creating external calendar 
	causes local calendar to be in an inconsistent state
	
	Changeset:
	1.) ZmCalendarTreeController.js - 
	(a.) Reverted the change done for Bug: 82811
	(b.) In ZmCalendarTreeController::_newListener, introduced a new 
	param isExternalCalendar that helps decide which dialog to render. 
	The bug was due to improper dialog popping up, e.g. add an external 
	calendar (ical or cal dav), then add a local calendar which still 
	retains the URL of remote folder.
	
	2.) ZmExternalCalendarDialog.js - 
	In ZmExternalCalendarDialog::_nextButtonListener, passing a param 
	isExternalCalendar => true while invoking 
	ZmCalendarTreeController::_newListener.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=85158

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/controller/ZmCalendarTreeController.js#125 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/view/ZmExternalCalendarDialog.js#11 edit
Change 532718 by achhatre@achhatre_mac on 2014/12/24 00:31:26

	Merging using main_to_JUDASPRIEST
	
	Change 532483 by achhatre@achhatre_mac on 2014/12/22 04:10:15
	
	Bug: 85158, Bug: 82811 - Impossible to create an external caldav 
	calendar, Creating local calendar after creating external calendar 
	causes local calendar to be in an inconsistent state
	
	Changeset:
	1.) ZmCalendarTreeController.js - 
	(a.) Reverted the change done for Bug: 82811
	(b.) In ZmCalendarTreeController::_newListener, introduced a new 
	param isExternalCalendar that helps decide which dialog to render. 
	The bug was due to improper dialog popping up, e.g. add an external 
	calendar (ical or cal dav), then add a local calendar which still 
	retains the URL of remote folder.
	
	2.) ZmExternalCalendarDialog.js - 
	In ZmExternalCalendarDialog::_nextButtonListener, passing a param 
	isExternalCalendar => true while invoking 
	ZmCalendarTreeController::_newListener.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=85158

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/controller/ZmCalendarTreeController.js#5 integrate
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/view/ZmExternalCalendarDialog.js#2 integrate
Bug 96123
User wants to be able to use "/" and quotes in task titles
Change 534737 by vbellows@vbellows-JP on 2015/01/21 09:25:37

	Bug: 96123 - User wants to be able to use "/" and quotes in task 
	titles
	
	A incorrect request was made to limit the characters usable in a 
	task subject.  Removed the subject validation regex.
	Tested a subject name -   ~`!@#$%^&*()_-+=|\}]{["':;?/>.<,
	
	Reverts a portion of CL 491732, 11/19/13.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96123

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/tasks/view/ZmTaskEditView.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/tasks/view/ZmTaskListView.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#25 edit
Change 534738 by vbellows@vbellows-main on 2015/01/21 09:29:48

	Bug: 96123 - User wants to be able to use "/" and quotes in task 
	titles
	A incorrect request was made to limit the characters usable in a 
	task subject.  Removed the subject validation regex.
	Tested a subject name -   ~`!@#$%^&*()_-+=|\}]{["':;?/>.<,
	Reverts a portion of CL 491732, 11/19/13.
	
	Merging
	//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/...
	to //depot/zimbra/main/ZimbraWebClient/WebRoot/...
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96123

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/tasks/view/ZmTaskEditView.js#79 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/tasks/view/ZmTaskListView.js#139 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#1147 integrate
Bug 96134
Announce toast messages live through screen readers
Change 531145 by dchristiansen@dchristiansen-box-2 on 2014/12/05 
	09:18:51

	bug 96134 - make screen readers announce status messages
	
	We do this by making the toast itself an alert and a live region, and
	by assigning an alternate text to the toast icon. In order to make
	this work reliably, we clear the toast contents when hiding it;
	otherwise we wouldn't announce, say, multiple draft saves.
	
	Please note that this differs from the approach used during the
	Comcast effort. Back then, we expected to announce many other 
	messages
	to the user, so we added a notion of a 'shared' live region which we
	used for all notices, including toasts. This would have allowed us to
	use a single 'log' for all notices -- if it weren't for the fact that
	JAWS always reads entire live regions out loud. So we had different
	approaches for different browsers.
	
	Simply making the toast live has the advantage that we avoid adding
	new AT-only infrastructure. Instead, the toast simply gets read out
	loud.
	
	The main other use of live regions will be autocomplete, but I think
	we'd be better off by handling that as a separate issue.
	
	(As an additional minor cleanup, move the toast and status view to
	using DwtControl methods for affecting its element rather than Dwt
	methods.)
	
	Tested in Safari using VoiceOver as well as Firefox and Internet
	Explorer 11 using NVDA and JAWS.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96134

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtControl.js#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmStatusView.js#2 edit
Change 531146 by dchristiansen@dchristiansen-vmware on 2014/12/05 
	09:22:29

	bug 96134 - make screen readers announce status messages
	
	(Merging using main_to_JUDASPRIEST)
	
	We do this by making the toast itself an alert and a live region, and
	by assigning an alternate text to the toast icon. In order to make
	this work reliably, we clear the toast contents when hiding it;
	otherwise we wouldn't announce, say, multiple draft saves.
	
	Please note that this differs from the approach used during the
	Comcast effort. Back then, we expected to announce many other 
	messages
	to the user, so we added a notion of a 'shared' live region which we
	used for all notices, including toasts. This would have allowed us to
	use a single 'log' for all notices -- if it weren't for the fact that
	JAWS always reads entire live regions out loud. So we had different
	approaches for different browsers.
	
	Simply making the toast live has the advantage that we avoid adding
	new AT-only infrastructure. Instead, the toast simply gets read out
	loud.
	
	The main other use of live regions will be autocomplete, but I think
	we'd be better off by handling that as a separate issue.
	
	(As an additional minor cleanup, move the toast and status view to
	using DwtControl methods for affecting its element rather than Dwt
	methods.)
	
	Tested in Safari using VoiceOver as well as Firefox and Internet
	Explorer 11 using NVDA and JAWS.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96134

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtControl.js#136 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmStatusView.js#64 integrate
Bug 96141
Ensure that our editor is accessible
Change 533909 by dchristiansen@dchristiansen-box-2 on 2015/01/14 
	03:03:30

	bug 96141 - fix focusing editor in MSIE
	
	The previous approach -- focusing the IFRAME directly -- didn't work
	reliably as it bypassed tinyMCE's internal state. Instead, we make 
	the
	ZmHtmlEditor object itself forward focus to TinyMCE using the proper
	API.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96141

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#14 edit
Change 533910 by dchristiansen@dchristiansen-box-2 on 2015/01/14 
	03:04:01

	bug 96141 - compose view: remove spurious widget from tab order
	
	Preivously, the compose view would hide and show the containing 
	element for the
	identity select, but not the widget itself. This meant that
	DwtKeyboardMgr considered it focusable, and attempted to give it 
	focus.
	
	To address this, we also assign the visibility to the widget itself.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96141

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmComposeView.js#17 edit
Change 534675 by dchristiansen@dchristiansen-box-2 on 2015/01/21 
	02:18:27

	bug 96141 - TinyMCE build tweaks
	
	Add an ant target for building TinyMCE, speed up the build by
	skipping linting, and fix building TinyMCE on Linux.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96141

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/build.xml#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/Makefile#3 edit
Change 534677 by dchristiansen@dchristiansen-box-2 on 2015/01/21 
	02:22:58

	bug 96141 - editor fixes
	
	- prevent escape in TinyMCE menus from dismissing the tab
	- remove invalid aria-labelledby
	- fix aria-describedby for TinyMCE dialogs
	- fix form label for attributes when pointing to comboboxes
	- use the similarly named role for comboboxes
	- handle tabbing within TinyMCE
	
	I've posted them as pull requests on GitHub; I'll update them pending
	any feedback.
	
	https://github.com/tinymce/tinymce/pull/466
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96141

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/patches/02-fix-escape.diff#1 add
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/patches/03-spurious-aria-labelledby.diff#1 add
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/patches/04-fix-describedby.diff#1 add
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/patches/05-fix-table-border-target.diff#1 add
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/patches/06-combobox-role.diff#1 add
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/patches/07-tab-propagate.diff#1 add
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/Button.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/ComboBox.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/Form.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/KeyboardNavigation.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/Menu.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/MenuButton.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/Window.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.dev.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.jquery.dev.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.jquery.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.jquery.min.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.min.js#2 edit
Change 535021 by dchristiansen@dchristiansen-box-2 on 2015/01/23 
	02:54:14

	bug 96141 - update TinyMCE patches
	
	- Update the combobox patch to ensure that toolbar items get a role 
	of
	  button.
	- Update the tab propagation patch to ensure that direct float 
	panels,
	  such as the colour dropdowns, also keep focus.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96141

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/patches/06-combobox-role.diff#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/patches/07-tab-propagate.diff#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/ComboBox.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/FloatPanel.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/Menu.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/MenuButton.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/classes/ui/Window.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/skins/lightgray/skin.ie7.dev.less#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/skins/lightgray/skin.ie7.min.css#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/skins/lightgray/skin.min.css#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/skins/lightgray/skin.modern.dev.less#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.dev.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.jquery.dev.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.jquery.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.jquery.min.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.min.js#3 edit
Change 535026 by dchristiansen@dchristiansen-box-2 on 2015/01/23 
	03:02:58

	bug 96141 - TinyMCE CSS tweaks
	
	This updates our TinyMCE CSS overrides to make the editor toolbar 
	buttons more
	consistent with other buttons. In particular, the buttons would
	previously receive a blue background on hover, whereas they now only
	get the same blue border as other controls.
	
	In order to let our CSS rules override those from TinyMCE, I had to
	change the button background from 'transparent' to white; otherwise
	the server-side logic failed to output the background rules.
	
	The actual motivation, however, for digging into the CSS overrides 
	was
	that the text colour dropdowns had no focus indicator -- or rather,
	that the one they had was nearly impossible to see. As a simple fix,
	we apply a two-pixel outline to the individual colour boxes; this
	ensures that the highlight is both visible and stands out compared to
	the colour itself.
	
	(As an aside, the adjacent sibling combinator used for applying the
	border to focused buttons actually works in IE8. Provided you move 
	the
	mouse, that is... I consider this an acceptable level of failure for
	that browser.)
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96141

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/skins/harmony/editor.css#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/skins/harmony/skin.properties#2 edit
Bug 96142
Ensure that dialogs are accessible
Change 528805 by dchristiansen@dchristiansen-box-2 on 2014/11/14 
	03:44:46

	bug 96142, 96143 - basic accessibility for dialogs
	
	This involves assigning the appropriate roles and ARIA tags, and
	added an alternate text to message dialog icons.
	
	The approach used here is the generally recommended; the title is
	the ARIA label, and the dialog body is the description. During the
	Comcast effort, we found that this didn't work sufficiently well
	in some screen readers, and adopted an approach where we combined
	the two into the label. If needs be, we can adopt the same
	approach here, but I'm hoping that we won't have to.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96142
	https://bugzilla.zimbra.com/show_bug.cgi?id=96143

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/core/AjxImg.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtBaseDialog.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtDialog.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMessageDialog.js#2 edit
Change 528809 by dchristiansen@dchristiansen-vmware on 2014/11/14 
	03:46:00

	bug 96142, 96143 - basic accessibility for dialogs
	
	(Merging using main_to_JUDASPRIEST)
	
	This involves assigning the appropriate roles and ARIA tags, and
	added an alternate text to message dialog icons.
	
	The approach used here is the generally recommended; the title is
	the ARIA label, and the dialog body is the description. During the
	Comcast effort, we found that this didn't work sufficiently well
	in some screen readers, and adopted an approach where we combined
	the two into the label. If needs be, we can adopt the same
	approach here, but I'm hoping that we won't have to.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96142
	https://bugzilla.zimbra.com/show_bug.cgi?id=96143

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/core/AjxImg.js#43 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtBaseDialog.js#26 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtDialog.js#42 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMessageDialog.js#30 integrate
Change 532355 by jdam@jdam-node on 2014/12/19 05:09:53

	BUG 96142 Added tabbing in edit folder properties dialog.
	
	The DwtPropertySheet -- used for name, type, color, etc. in the 
	dialog --
	now adds every DOM child to its tabgroup. In addition, labels' for 
	attribute
	refers to the id of the value inserted.
	
	A tabgroup is added to ZmFolder(Property|Retention)View through
	the DwtPropertyPage class. Concrete members of it is added in the 
	two views.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96142

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtGrouper.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtPropertyPage.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtPropertySheet.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderPropertyView.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderPropsDialog.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderRetentionView.js#2 edit
Change 532356 by dchristiansen@dchristiansen-vmware on 2014/12/19 
	05:14:04

	BUG 96142 Added tabbing in edit folder properties dialog.
	
	(Merging using main_to_JUDASPRIEST)
	
	The DwtPropertySheet -- used for name, type, color, etc. in the 
	dialog --
	now adds every DOM child to its tabgroup. In addition, labels' for 
	attribute
	refers to the id of the value inserted.
	
	A tabgroup is added to ZmFolder(Property|Retention)View through
	the DwtPropertyPage class. Concrete members of it is added in the 
	two views.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96142

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtGrouper.js#16 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtPropertyPage.js#16 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtPropertySheet.js#23 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderPropertyView.js#25 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderPropsDialog.js#132 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderRetentionView.js#12 integrate
Change 534527 by rshah@rshah-JUDASPRIEST on 2015/01/19 16:50:16

	Bug 96142 - Ensure that dialogs are accessible
	Added tab groups and focus for the all the dialogs list as mentioned 
	in the bug.
	
	ZmNewTagDialog - Tab and focus works no change needed.
	ZmNewOrganizerDialog - Added missing items in tab group.
	ZmNewSearchDialog -  Tab and focus works no change needed.
	ZmFolderPropsDialog -  Tab and focus works no change needed.
	ZmLinkPropsDialog - Not sure where it is used
	ZmSharePropsDialog - Added tab support in ZmSharePropsDialog and 
	also added support for tab groups in DwtGrouper and ZmShareReply.
	DwtMessageDialog -  Tab and focus works no change needed.
	ZmErrorDialog -  Tab and focus works no change needed.
	ZmAttachDialog - This is partially done. For full support it needs 
	changes in ZmBriefcaseTabView. Since briefcase is not focus for this 
	release I have not modified it.
	ZmChooseFolderDialog -  Tab and focus works no change needed.
	ZmPickTagDialog -  Tab and focus works no change needed.
	
	ZmRenameTagDialog - Tab and focus works no change needed.
	ZmRenameFolderDialog - Tab and focus works no change needed.
	ZmShareSearchDialog - Partially working. Needs more work.
	ZmAcceptShareDialog - Added support for tab    
	ZmDeclineShareDialog - Added support for tab
	ZmRevokeShareDialog - Added support for tab
	ZmMailRedirectDialog - Partially working needs more work.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96142

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtGrouper.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmShareReply.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmAcceptShareDialog.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmAttachDialog.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmDeclineShareDialog.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmNewOrganizerDialog.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmRevokeShareDialog.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmSharePropsDialog.js#6 edit
Change 534957 by cdamon@cdamon_judaspriest on 2015/01/22 10:27:12

	Bug: 96142 - Ensure that dialogs are accessible
	
	Remove ZmLinkPropsDialog, which was used by
	the defunct Notebook app.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96142

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/core/ZmAppCtxt.js#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/package/Extras.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmLinkPropsDialog.js#2 delete
Bug 96143
Accessibility for message and confirmation dialogs
Change 528805 by dchristiansen@dchristiansen-box-2 on 2014/11/14 
	03:44:46

	bug 96142, 96143 - basic accessibility for dialogs
	
	This involves assigning the appropriate roles and ARIA tags, and
	added an alternate text to message dialog icons.
	
	The approach used here is the generally recommended; the title is
	the ARIA label, and the dialog body is the description. During the
	Comcast effort, we found that this didn't work sufficiently well
	in some screen readers, and adopted an approach where we combined
	the two into the label. If needs be, we can adopt the same
	approach here, but I'm hoping that we won't have to.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96142
	https://bugzilla.zimbra.com/show_bug.cgi?id=96143

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/core/AjxImg.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtBaseDialog.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtDialog.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMessageDialog.js#2 edit
Change 528809 by dchristiansen@dchristiansen-vmware on 2014/11/14 
	03:46:00

	bug 96142, 96143 - basic accessibility for dialogs
	
	(Merging using main_to_JUDASPRIEST)
	
	This involves assigning the appropriate roles and ARIA tags, and
	added an alternate text to message dialog icons.
	
	The approach used here is the generally recommended; the title is
	the ARIA label, and the dialog body is the description. During the
	Comcast effort, we found that this didn't work sufficiently well
	in some screen readers, and adopted an approach where we combined
	the two into the label. If needs be, we can adopt the same
	approach here, but I'm hoping that we won't have to.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96142
	https://bugzilla.zimbra.com/show_bug.cgi?id=96143

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/core/AjxImg.js#43 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtBaseDialog.js#26 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtDialog.js#42 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMessageDialog.js#30 integrate
Bug 96144
Accessible display of account name and quota
Change 532439 by cdamon@cdamon_judaspriest on 2014/12/20 11:16:19

	Bug: 96144 - Accessible display of account name and quota
	
	Add the username and quota to the tab order. They are added
	as generic DwtComposite instances.
	
	- add both to root tab group after search bar, before help button
	- make both focusable
	- set ARIA text
	- add 'isFocusable' and 'role' as params to DwtControl ctor
	- add new debug level 'focus1' to just see what has focus
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96144

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/debug/AjxDebug.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtTabGroup.js#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtControl.js#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/core/ZmZimbraMail.js#9 edit
Bug 96442
Accessible autocomplete
Change 534431 by dchristiansen@dchristiansen-imac on 2015/01/19 
	02:14:20

	bug 96442 - tab in autocomplete input is not a separator
	
	Previously, hitting a tab in autocomplete with a field selected
	would insert that value and retain focus within the input field. I
	believe this is inconsistent with the expectations of a blind
	user, where tab should _always_ move focus to the "next"
	control. I'm not entirely certain whether we should retain the
	current value or not, but I opted for the latter, since it's
	consistent with moving focus using the mouse.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96442

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmAutocompleteListView.js#2 edit
Change 534432 by dchristiansen@dchristiansen-box-2 on 2015/01/19 
	02:19:23

	bug 96442 - accessible autocomplete
	
	This change adds accessibility support for the 
	ZmAutocompleteListView,
	enabling visually impaired users to enter email addresses in a 
	fashion
	similar to sighted users.
	
	We deviate slightly from the recommendations of the WAI-ARIA 
	Authoring
	Practices:[1] They require entering the choice into textbox, but that
	doesn't work well with our semi-magic address bubbles. Instead, we 
	use
	an ARIA live region[2] for announcing the presence of autocomplete,
	its matches and what we enter. This may be a bit too verbose for 
	blind
	people, but I consider that ok as removing announcements is a trivial
	change.
	
	From my testing, the code used for the ARIA live region works well in
	the following browsers and screen readers:
	
	- Safari & VoiceOver
	- Chrome & VoiceOver
	- Internet Explorer & NVDA
	- Internet Explorer & JAWS
	- Firefox & NVDA
	- Firefox & JAWS
	
	As such, it's a useful piece of code to factor out, should the need
	for live regions arise elsewhere.
	
	(I could not get the live region to work in Chrome on Windows, but
	that may be a bug in Chrome; the same applied to our toast messages 
	as
	well as some live region examples I found online. Similarly, Firefox
	on OS X seemed generally inaccessible.)
	
	[1] http://www.w3.org/TR/wai-aria-practices/#autocomplete
	[2] 
	https://developer.mozilla.org/docs/Web/Accessibility/ARIA/ARIA_Live_R
	egions
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96442

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmAddressInputField.js#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmAutocompleteListView.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#23 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/templates/share/Widgets.template#3 edit
Change 535309 by dchristiansen@dchristiansen-box-2 on 2015/01/27 
	05:18:31

	bug 96442, 97465 - accessible address field DL expansion
	
	This adds keyboard accessibility for expanding distribution lists in
	the autocomplete dropdown. Users may expand a distribution list by
	hitting the right arrow with the caret at the end of the input; they
	can collapse it by hitting the left arrow key.
	
	This also fixes the case of autocomplete lines with no corresponding
	match -- bug 97465 -- by simply using the textual contents of the 
	line.
	
	In order to have a good keyboard experience, we change the initial
	selection of the nested list to always be its first element, which
	typically describes its size or lack of members. This should not
	affect any existing users, as the only way to trigger this menu
	previously was with the mouse.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96442
	https://bugzilla.zimbra.com/show_bug.cgi?id=97465

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmAutocompleteListView.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmDLAutocompleteListView.js#2 edit
Bug 96561
Make contact picker accessible
Change 532899 by rshah@rshah-JUDASPRIEST on 2014/12/29 03:00:38

	Bug 96561 - Make contact picker accessible
	Added the tabgroup for making it keyboard accessible.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96561

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtChooser.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/abook/view/ZmContactPicker.js#6 edit
Bug 96670
Changing "Group by" option causes object undefined error (this._colHeaderActionMenu.getMenuItem)
Change 530608 by vbellows@vbellows-JP on 2014/12/02 09:33:35

	Bug: 96670 -  Changing "Group by" option causes object undefined 
	error (this._colHeaderActionMenu.getMenuItem)
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96670

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmMailListView.js#4 edit
Change 530610 by vbellows@vbellows-main on 2014/12/02 09:38:25

	Bug: 96670 -  Changing "Group by" option causes object undefined 
	error (this._colHeaderActionMenu.getMenuItem)
	Merging
	//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail
	/view/ZmMailListView.js to 
	//depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/Z
	mMailListView.js
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96670

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmMailListView.js#257 integrate
Bug 96686
Shortcut to show context menu does not work
Change 533974 by cdamon@cdamon_judaspriest on 2015/01/14 17:12:02

	Bug: 96686 - Shortcut to show context menu does not work
	
	Restore context menu shortcut to lists and trees. It is now
	DwtKeyMap.SUBMENU instead of DwtKeyMap.ACTION.
	Note that lists and trees do not support the DownArrow
	as a context menu shortcut, since they use it for navigation.
	
	- remove some useless jsdoc stuff
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96686

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtKeyMap.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtListView.js#9 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtTreeItem.js#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/AjxKeys.properties#4 edit
Bug 96716
New message always added to bottom of conv, despite setting order as new-to-old
Change 530905 by cdamon@cdamon_judaspriest on 2014/12/03 18:30:33

	Bug: 96716 - New message always added to bottom of conv, despite 
	setting order as new-to-old
	
	For accessibility, we interposed a container DIV to hold
	each msg view. That container DIV was being appended to
	the messages list, so new msg views were always added at
	the bottom. The fix is to use the index to add the container
	DIV to the right spot in the messages list.
	
	Additionally, these container DIVs were not being cleaned
	up, so they accumulated and threw off the indexes, causing
	new messages to be added at the top even if the user is
	ordering messages from old to new. The container DIVs are
	now removed during reset().
	
	Fix the msg count in the aria-label. It was skipping (1 of 15,
	3 of 15, etc) since we were adding the ID to this._msgViewList
	twice.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96716

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmConvView2.js#11 edit
Bug 96727
CalDAV:Sending invite to external user sends 2 invitations
Change 532083 by gren.elliot@gelliot_coco on 2014/12/15 12:51:11

	bug: 96727
	
	Double invites sent out to external attendee.
	Root cause was a recent change to replace null origInvites with an 
	empty list but there was still code assuming no old invites meant 
	origInvites was null.  Ended up in code used for updates instead of 
	new creations.
	https://reviewboard.eng.zimbra.com/r/3403/
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96727

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/dav/caldav/AutoScheduler.java#3 edit
Change 532095 by gren.elliot@gelliot_coco on 2014/12/15 15:00:28

	bug: 96727
	
	Double invites sent out to external attendee.
	Root cause was a recent change to replace null origInvites with an 
	empty list but there was still code assuming no old invites meant 
	origInvites was null.  Ended up in code used for updates instead of 
	new creations.
	https://reviewboard.eng.zimbra.com/r/3403/
	JP ---> main
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96727

Affected files ...

... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/dav/caldav/AutoScheduler.java#3 integrate
Bug 96728
Responding to exception in MacOutlook fails
Change 531002 by rdesai@rdesai_macbook_z on 2014/12/04 10:55:02

	Bug: 96728 
	Responding to exception in MacOutlook fails 
	
	This issue occurred because the acceptance response is now sent with 
	invite maiItemId instead of instance index.
	Fixed the logic to determine invite. It now tries to see if 
	instanceIndex is actually an invite itemId if not then it is 
	considered instance index.
	Verified by creating recur appts and creating exceptions. accepted 
	exception both through Calendar and Invite message.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96728

Affected files ...

... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/ews/util/CalendarUtil.java#22 edit
Change 531003 by rdesai@rdesai_macbook_z on 2014/12/04 10:56:34

	Merging from main
	
	Bug: 96728 
	Responding to exception in MacOutlook fails 
	
	This issue occurred because the acceptance response is now sent with 
	invite maiItemId instead of instance index.
	Fixed the logic to determine invite. It now tries to see if 
	instanceIndex is actually an invite itemId if not then it is 
	considered instance index.
	Verified by creating recur appts and creating exceptions. accepted 
	exception both through Calendar and Invite message.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96728

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/ews/util/CalendarUtil.java#4 integrate
Change 533207 by rdesai@rdesai_macbook_z on 2015/01/05 02:00:45

	Bug: 96728
	Responding to exception in MacOutlook fails
	
	Unable to reproduce the issue seen in Comment#6 of the Bug
	However fixed some of the issue that was seen
	  With no attendee list received with UpdateItem from Outlook
	  Response status of an attendee being incorrect
	  Accept/Decline/Tentative buttons disappearing after responding to 
	an appointment
	  Tested with both Recur and non recur appts. 
	  Tested  Accept/Decline/Tentative  for appts and exceptions to 
	recur appt
	  Tested with shared calendar on another mail store
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96728

Affected files ...

... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/ews/service/ItemService.java#36 edit
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/ews/service/ServiceResponseBuilder.java#65 edit
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/ews/util/CalendarUtil.java#23 edit
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/operation/CalendarOperation.java#34 edit
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/operation/EmailOperation.java#37 edit
Change 533208 by rdesai@rdesai_macbook_z on 2015/01/05 02:02:41

	Merging from main
	
	Bug: 96728
	Responding to exception in MacOutlook fails
	
	Unable to reproduce the issue seen in Comment#6 of the Bug
	However fixed some of the issue that was seen
	  With no attendee list received with UpdateItem from Outlook
	  Response status of an attendee being incorrect
	  Accept/Decline/Tentative buttons disappearing after responding to 
	an appointment
	  Tested with both Recur and non recur appts. 
	  Tested  Accept/Decline/Tentative  for appts and exceptions to 
	recur appt
	  Tested with shared calendar on another mail store
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96728

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/ews/service/ItemService.java#9 integrate
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/ews/service/ServiceResponseBuilder.java#12 integrate
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/ews/util/CalendarUtil.java#5 integrate
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/operation/CalendarOperation.java#10 integrate
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/operation/EmailOperation.java#6 integrate
Change 533588 by rdesai@rdesai_macbook_z on 2015/01/08 22:24:34

	Bug: 96728
	Responding to exception in MacOutlook fails
	 - Fixed a bug introduced in sending email from Outlook while fixing 
	BUg 96728
	- Verified that email can be sent, with/without attachment.
	- Verified email reply/forward works
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96728

Affected files ...

... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/operation/EmailOperation.java#38 edit
Change 533589 by rdesai@rdesai_macbook_z on 2015/01/08 22:25:57

	Merging from main
	
	Bug: 96728
	Responding to exception in MacOutlook fails
	 - Fixed a bug introduced in sending email from Outlook while fixing 
	BUg 96728
	- Verified that email can be sent, with/without attachment.
	- Verified email reply/forward works
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96728

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/operation/EmailOperation.java#7 integrate
Change 536232 by rdesai@rdesai_macbook_z on 2015/02/05 04:05:52

	Bug: 96728
	
	
	Fixed issue 'Accept/decline/tentative accept exception occurrence 
	(Calendar) >> Failed'
	Added code to load the instance invite instead of the defalt invite
	Fixed the issue with Accept/decline/tentative status being not 
	correctly reflected on the organizer calendar
	
	Tested
	Accept/decline/tentative accept regular meeting (from 
	Inbox/Calendar) 
	Accept/decline/tentative accept recurring series (from 
	Inbox/Calendar) 
	Accept/decline/tentative accept exception occurrence (Inbox)
	Accept/decline/tentative accept exception occurrence (Calendar)
	Send email - plain, html, attachments
	Reply/Forward email - plain, html, attachments 
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96728

Affected files ...

... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/ews/service/ServiceResponseBuilder.java#66 edit
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/operation/EmailOperation.java#39 edit
Change 536233 by rdesai@rdesai_macbook_z on 2015/02/05 04:07:55

	Merging from main
	
	Bug: 96728
	
	
	Fixed issue 'Accept/decline/tentative accept exception occurrence 
	(Calendar) >> Failed'
	Added code to load the instance invite instead of the defalt invite
	Fixed the issue with Accept/decline/tentative status being not 
	correctly reflected on the organizer calendar
	
	Tested
	Accept/decline/tentative accept regular meeting (from 
	Inbox/Calendar) 
	Accept/decline/tentative accept recurring series (from 
	Inbox/Calendar) 
	Accept/decline/tentative accept exception occurrence (Inbox)
	Accept/decline/tentative accept exception occurrence (Calendar)
	Send email - plain, html, attachments
	Reply/Forward email - plain, html, attachments 
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96728

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/ews/service/ServiceResponseBuilder.java#13 integrate
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/operation/EmailOperation.java#8 integrate
Change 537056 by rdesai@rdesai_macbook_z on 2015/02/13 03:16:00

	Bug: 96728
	
	Bug: 96728
	
	
	Fixed issue when accept/decline/tentative accept/ of an 
	occurence(not exception) from the Calendar
	Added code to create a local exception based on the index of the 
	occurrence
	Find an issue (user status was being cleared), when Outlook send am 
	updateItem immeditely after an occurence is accepted. Fixed the 
	updateItem code.
	
	Tested
	Accept/decline/tentative accept regular meeting (from 
	Inbox/Calendar) 
	Accept/decline/tentative accept recurring series (from 
	Inbox/Calendar) 
	Accept/decline/tentative accept exception occurrence (Inbox)
	Accept/decline/tentative accept exception occurrence (Calendar)
	Send email - plain, html, attachments
	Reply/Forward email - plain, html, attachments 
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96728

Affected files ...

... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/operation/CalendarOperation.java#35 edit
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/operation/EmailOperation.java#40 edit
Change 537057 by rdesai@rdesai_macbook_z on 2015/02/13 03:19:08

	Merging from main
	
	Bug: 96728  Responding to exception in MacOutlook fails
	
	
	Fixed issue when accept/decline/tentative accept/ of an 
	occurence(not exception) from the Calendar
	Added code to create a local exception based on the index of the 
	occurrence
	Find an issue (user status was being cleared), when Outlook sent an 
	updateItem immeditely after an occurence is accepted. Fixed the 
	updateItem code.
	
	Tested
	Accept/decline/tentative accept regular meeting (from 
	Inbox/Calendar) 
	Accept/decline/tentative accept recurring series (from 
	Inbox/Calendar) 
	Accept/decline/tentative accept exception occurrence (Inbox)
	Accept/decline/tentative accept exception occurrence (Calendar)
	Send email - plain, html, attachments
	Reply/Forward email - plain, html, attachments 
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96728

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/operation/CalendarOperation.java#11 integrate
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/operation/EmailOperation.java#9 integrate
Bug 96742
Time selection defaults to midnight
Change 530904 by vbellows@vbellows-JP on 2014/12/03 18:28:48

	Bug: 96742 -  Time selection defaults to midnight
	
	
	Accessibility changes in DwtMenu and DwtButton were resetting the 
	selected item to the first item in the menu.  For time selection, 
	I've moved the scrolling (to position to the current time value) to 
	be after DwtButton.popup, which is where the menu.setSelectedItem(0) 
	calls occur.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96742

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtTimeSelect.js#2 edit
Change 531158 by vbellows@vbellows-main on 2014/12/05 09:33:42

	Bug: 96742 -  Time selection defaults to midnight
	
	
	Accessibility changes in DwtMenu and DwtButton were resetting the 
	selected item to the first item in the menu.  For time selection, 
	I've moved the scrolling (to position to the current time value) to 
	be after DwtButton.popup, which is where the menu.setSelectedItem(0) 
	calls occur.
	
	Merging
	//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widget
	s/DwtTimeSelect.js to 
	//depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtTi
	meSelect.js
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96742

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtTimeSelect.js#4 integrate
Bug 96743
Time Selection quarter-hour submenu incorrectly highlighted
Change 531380 by vbellows@vbellows-JP on 2014/12/08 11:10:05

	Bug: 96743 -  Time Selection quarter-hour submenu incorrectly 
	highlighted
	
	- Made changes so that the timeSelect minutes submenu does not get 
	focus when it pops up, using _preventMenuFocus.   Note, I modified 
	DwtMenu._doPopup to add the submenu to tabs even when 
	_preventMenuFocus is set, but prevent it from grabbing focus in that 
	case.
	
	- Also, the time input field was not working.  After popping up the 
	hour menu, the input field did not react to attempts to edit it.  It 
	turns out the handleTimeChange function was being invoked onFocus 
	for the input field, and it in turn now causes focus to be handed 
	off to the hour menu.  So the input field could never receive focus.  
	I removed the onFocus call (there still is a handleTimeChange call 
	onBlur, which makes more sense), and it seems to work properly.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96743

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtKeyboardMgr.js#8 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMenu.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtTimeSelect.js#3 edit
Change 531386 by vbellows@vbellows-main on 2014/12/08 11:16:03

	Bug: 96743 -  Time Selection quarter-hour submenu incorrectly 
	highlighted
	
	- Made changes so that the timeSelect minutes submenu does not get 
	focus when it pops up, using _preventMenuFocus.   Note, I modified 
	DwtMenu._doPopup to add the submenu to tabs even when 
	_preventMenuFocus is set, but prevent it from grabbing focus in that 
	case.
	
	- Also, the time input field was not working.  After popping up the 
	hour menu, the input field did not react to attempts to edit it.  It 
	turns out the handleTimeChange function was being invoked onFocus 
	for the input field, and it in turn now causes focus to be handed 
	off to the hour menu.  So the input field could never receive focus.  
	I removed the onFocus call (there still is a handleTimeChange call 
	onBlur, which makes more sense), and it seems to work properly.
	
	Merging
	//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/... 
	to 
	//depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/...
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96743

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtKeyboardMgr.js#71 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMenu.js#88 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtTimeSelect.js#5 integrate
Bug 96756
In compose, cannot tab into body area
Change 531065 by cdamon@cdamon_judaspriest on 2014/12/04 17:58:08

	Bug: 96756 - In compose, cannot tab into body area
	
	Move editor tab setup into a separate function called
	during init, instead of splitting HTML and TEXT mode
	into different areas. Create a tab subgroup for each
	mode and swap in the right one based on the mode.
	
	Tested and appears to work on initial compose, after
	switching formats, and after changing the preference.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96756

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#10 edit
Bug 96780
Scrolling of new / unread messages broken with CLV and reading pane on
Change 531257 by cdamon@cdamon_judaspriest on 2014/12/05 19:22:42

	Bug: 96780 - Scrolling of new / unread messages broken with CLV and 
	reading pane on
	
	Container elements for a conv's msg views were added
	in 529576/96140, so we can no longer use "el.nextSibling"
	to get the next msg view. Add a function to get the next
	msg view based on a msg ID.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96780

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmConvView2.js#12 edit
Bug 96815
Copy/Paste of Excel/Word data results in image inserted into MIME
Bug 96848
Attached mail in compose window doesn't get open.
Change 532195 by vbellows@vbellows-JP on 2014/12/17 10:39:37

	Bug: 96848 - Attached mail in compose window doesn't get opened.
	
	
	Unlike other attachments, a mail message attachment is displayed 
	using an onClick event hander.   Focus changes for accessibility 
	were clearing out the link's eventHandlers and attaching DwtControl 
	handlers.  This CL adds an exclusion list to the 
	DwtControl._makeFocusable and _setEventHdlrs.  Since the message 
	attachment click displays a separate window with the message 
	contents, I'm ok with click on the link not receiving focus onClick.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96848

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmComposeView.js#15 edit
Change 532196 by vbellows@vbellows-main on 2014/12/17 10:42:29

	Bug: 96848 - Attached mail in compose window doesn't get opened.
	Unlike other attachments, a mail message attachment is displayed 
	using an onClick event hander.   Focus changes for accessibility 
	were clearing out the link's eventHandlers and attaching DwtControl 
	handlers.  This CL adds an exclusion list to the 
	DwtControl._makeFocusable and _setEventHdlrs.  Since the message 
	attachment click displays a separate window with the message 
	contents, I'm ok with click on the link not receiving focus onClick.
	
	Merging
	//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail
	/view/ZmComposeView.js to 
	//depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/Z
	mComposeView.js
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96848

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmComposeView.js#765 integrate
Bug 96984
missing localizations on View menu
Change 532311 by jbryan@jbryan-mbp-main on 2014/12/18 17:18:39

	bug: 96984
	* Add missing localized keys for 'Reading Pane' and 'Expand 
	Conversations'
	* Updated clientWhatsThisMessage and 
	clientWhatsThisMessageWithoutTablet to include modified HTML.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=96984

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_ar.properties#167 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_da.properties#164 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_de.properties#164 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_en_AU.properties#156 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_en_GB.properties#154 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_es.properties#170 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_fr.properties#182 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_fr_CA.properties#11 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_hi.properties#165 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_hu.properties#44 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_it.properties#166 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_ko.properties#167 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_ms.properties#25 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_nl.properties#174 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_pl.properties#163 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_pt.properties#25 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_pt_BR.properties#164 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_ro.properties#44 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_ru.properties#169 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_sl.properties#10 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_sv.properties#165 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_th.properties#30 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_tr.properties#153 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_uk.properties#44 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_zh_CN.properties#163 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_zh_HK.properties#163 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg_zh_TW.properties#22 edit
Bug 97031
zimbraCsrfTokenData cache inconsistency causes auth failure
Change 533767 by rdesai@rdesai_macbook_z on 2015/01/12 22:21:55

	Bug: 97031 zimbraCsrfTokenData cache inconsistency causes auth 
	failure 
	
	Unable to reproduce the Auth failure mentioned in Bug 97115 or 97031
	However making the following fixes
	- Load Account object from LDAP rather than Cache only for 
	isCsrfTokenCreated(), validation of CSRF token fails and storing 
	CSRF token this happens during token generation
	- Modified when isCsrfTokenCreated() is called from every 
	HttpRequest to only when --> auth token is present + CSRF bit in 
	auth token is disbaled  + POST request
	- Separate out the ADD and Delete operation and throw an exception 
	if any of the add or delete operation.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97031

Affected files ...

... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/servlet/CsrfFilter.java#11 edit
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/servlet/util/CsrfUtil.java#10 edit
Change 533768 by rdesai@rdesai_macbook_z on 2015/01/12 22:22:58

	Merging from main
	
	Bug: 97031 zimbraCsrfTokenData cache inconsistency causes auth 
	failure 
	
	Unable to reproduce the Auth failure mentioned in Bug 97115 or 97031
	However making the following fixes
	- Load Account object from LDAP rather than Cache only for 
	isCsrfTokenCreated(), validation of CSRF token fails and storing 
	CSRF token this happens during token generation
	- Modified when isCsrfTokenCreated() is called from every 
	HttpRequest to only when --> auth token is present + CSRF bit in 
	auth token is disbaled  + POST request
	- Separate out the ADD and Delete operation and throw an exception 
	if any of the add or delete operation.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97031

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/servlet/CsrfFilter.java#2 integrate
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/servlet/util/CsrfUtil.java#3 integrate
Bug 97096
Duplicate image when attached to the message body
Change 533710 by vbellows@vbellows-JP on 2015/01/12 09:38:16

	Bug: 97096 - Duplicate image when attached to the message body 
	
	The tinyMCE editor will insert the image from dnd, triggering its 
	own onPaste event.  This will read the image file and insert it into 
	the document (img src = 'data:...').   The image is also uploaded to 
	the server via the UploadManager; its _completeAll does a callback 
	that triggers a ZmComposeController.saveDraft, which eventually 
	leads to a call to ZmComposeController._processImages, which starts 
	another upload of the image.  Later in the save the attachment is 
	inserted into the document (via ZmHtmlEditor.insertImage).
	
	I'm setting paste_data_images to false  (a tinyMCE setting).  Now 
	for drag and drop images are only added via the UploadManager, the 
	excel paste properly (we update its borders in pastePostProcess), 
	and other file types are added as attachments.  The image paste 
	toolbar command works OK.
	
	It turns out pasting part of an Excel spreadsheet is pasting it as 
	an image (Its clipboard data included several variants - if 
	paste_data_images is true, that gets selected).    See Bug 96869, 
	'Copying excel spreadsheet doesnt show borders'
	This should also take care of Bug 95917, 'Firefox hangs pasting 
	large image' since the image is no longer being read, base64 
	encoded, and stored into the document.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97096

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#13 edit
Change 533711 by vbellows@vbellows-main on 2015/01/12 09:44:05

	Bug: 97096 - Duplicate image when attached to the message body 
	The tinyMCE editor will insert the image from dnd, triggering its 
	own onPaste event.  This will read the image file and insert it into 
	the document (img src = 'data:...').   The image is also uploaded to 
	the server via the UploadManager; its _completeAll does a callback 
	that triggers a ZmComposeController.saveDraft, which eventually 
	leads to a call to ZmComposeController._processImages, which starts 
	another upload of the image.  Later in the save the attachment is 
	inserted into the document (via ZmHtmlEditor.insertImage).
	
	I'm setting paste_data_images to false  (a tinyMCE setting).  Now 
	for drag and drop images are only added via the UploadManager, the 
	excel paste works properly (we update its borders in 
	pastePostProcess), and other file types are added as attachments.  
	The image paste toolbar command works OK.
	
	It turns out pasting part of an Excel spreadsheet is pasting it as 
	an image (Its clipboard data included several variants - if 
	paste_data_images is true, the image gets selected).    See Bug 
	96869, 'Copying excel spreadsheet doesnt show borders'
	This should also take care of Bug 95917, 'Firefox hangs pasting 
	large image' since the image is no longer being read, base64 
	encoded, and stored into the document.
	
	Merging
	//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/shar
	e/view/htmlEditor/ZmHtmlEditor.js
	to 
	//depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/
	htmlEditor/ZmHtmlEditor.js
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97096

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#270 integrate
Bug 97127
"[object Object]" appears in toast message when delete email from new window
Change 536053 by cdamon@cdamon_judaspriest_860 on 2015/02/03 16:28:41

	Bug: 97127 - "[object Object]" appears in toast message when delete 
	email from new window
	
	Instead of checking prototype, test the value of toString()
	against the generic "[object Object]".
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97127

Affected files ...

... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/ajax/util/AjxUtil.js#3 edit
Bug 97161
range dropdowns don't expand in "Folder properties">"Retention" tab
Change 533831 by vbellows@vbellows-JP on 2015/01/13 09:25:02

	Bug: 97161 -  range dropdowns don't expand in "Folder 
	properties">"Retention" tab
	
	The dialog background div is  marked as isFocusable, which causes 
	DwtControl event handlers to be added to the div.  The onMouseDown 
	was not being propagated to the select control. 
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97161

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderRetentionView.js#3 edit
Change 533836 by vbellows@vbellows-main on 2015/01/13 09:28:31

	Bug: 97161 -  range dropdowns don't expand in "Folder 
	properties">"Retention" tab
	
	The dialog background div is  marked as isFocusable, which causes 
	DwtControl event handlers to be added to the div.  The onMouseDown 
	was not being propagated to the select control. 
	
	Merging
	//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/shar
	e/view/dialog/ZmFolderRetentionView.js
	to 
	//depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/
	dialog/ZmFolderRetentionView.js
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97161

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderRetentionView.js#13 integrate
Bug 97170
Can't stop dragging new appointment dialog
Change 533832 by vbellows@vbellows-JP on 2015/01/13 09:25:21

	Bug:  97170 - Can't stop dragging new appointment dialog 
	
	Actually, all dialogs are affected (tried Folder Props, Share, etc).
	
	Accessibility changes to the baseDialog added a number of event 
	handlers, which prevented propagation of the event to 
	DwtDraggable._end function.  
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97170

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtBaseDialog.js#5 edit
Change 533837 by vbellows@vbellows-main on 2015/01/13 09:29:13

	Bug:  97170 - Can't stop dragging new appointment dialog 
	Actually, all dialogs are affected (tried Folder Props, Share, etc).
	Accessibility changes to the baseDialog added a number of event 
	handlers, which prevented propagation of the event to 
	DwtDraggable._end function.  
	
	Merging
	//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widget
	s/DwtBaseDialog.js
	to 
	//depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtBa
	seDialog.js
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97170

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtBaseDialog.js#29 integrate
Bug 97184
Folder tree in "Attach Contact" dialog broken
Change 533567 by eyarkon@eyarkon-JUDASPRIEST on 2015/01/08 14:34:13

	Bug 97184
	
	Folder tree in "Attach Contact" dialog broken
	
	
	Shorter description/repro steps would be - the folder tree in the 
	attach contact dialog doesn't do anything. Clicking on folders does 
	not change the current contacts displayed.
	
	Not sure why it broke (maybe related to accessibility or something, 
	but just a guess), but the code was setting the callback for 
	clicking in a weird way, with onclick on a container of the entire 
	tree. I just replaced it with more higher level standard of adding a 
	selection listener to the tree view.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97184

Affected files ...

... //depot/zimbra/JUDASPRIEST/Zimlet/src/zimlet/com_zimbra_attachcontacts/AttachContactsTabView.js#2 edit
Bug 97249
Message tab accessibility
Change 533735 by dchristiansen@dchristiansen-box-2 on 2015/01/12 
	14:17:17

	bug 97249 - keyboard accessibility for message/conv app tab
	
	This involves ensuring that a dedicated message tab works as 
	expected;
	i.e. you can tab into its contents, just like when viewing within the
	double pane.
	
	The main issue was that the double pane immediately stole focus from
	the tab -- in what appears to be an effort to work around IFRAME 
	focus
	issues. Additionally, we ensure that we never add elements twice and
	handle a missing navigation toolbar.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97249

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtText.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/controller/ZmDoublePaneController.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/controller/ZmMsgController.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmDoublePaneView.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmMailMsgView.js#8 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/controller/ZmListController.js#4 edit
Change 533736 by dchristiansen@dchristiansen-box-2 on 2015/01/12 
	14:17:46

	bug 97249 - keyboard accessibility for conversations
	
	This ensures that users can expand and collapse conversations while
	they have keyboard focus.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97249

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/events/DwtUiEvent.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/controller/ZmConvListController.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmConvView2.js#14 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys.properties#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_ar.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_da.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_de.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_en_AU.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_en_GB.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_es.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_eu.properties#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_fr.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_fr_CA.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_hi.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_hu.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_it.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_ko.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_ms.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_nl.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_pl.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_pt.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_pt_BR.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_ro.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_ru.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_sl.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_sv.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_th.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_tr.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_uk.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_zh_CN.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_zh_HK.properties#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/keys/ZmKeys_zh_TW.properties#4 edit
Change 533737 by dchristiansen@dchristiansen-vmware on 2015/01/12 
	14:19:04

	bug 97249 - keyboard accessibility for message/conv app tab
	
	(Merging using main_to_JUDASPRIEST)
	
	This involves ensuring that a dedicated message tab works as 
	expected;
	i.e. you can tab into its contents, just like when viewing within the
	double pane.
	
	The main issue was that the double pane immediately stole focus from
	the tab -- in what appears to be an effort to work around IFRAME 
	focus
	issues. Additionally, we ensure that we never add elements twice and
	handle a missing navigation toolbar.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97249

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtText.js#20 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/controller/ZmDoublePaneController.js#250 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/controller/ZmMsgController.js#161 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmDoublePaneView.js#93 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmMailMsgView.js#691 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/controller/ZmListController.js#396 integrate
Change 533738 by dchristiansen@dchristiansen-vmware on 2015/01/12 
	14:19:32

	bug 97249 - keyboard accessibility for conversations
	
	(Merging using main_to_JUDASPRIEST)
	
	This ensures that users can expand and collapse conversations while
	they have keyboard focus.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97249

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/events/DwtUiEvent.js#24 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/controller/ZmConvListController.js#205 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmConvView2.js#319 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys.properties#98 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_ar.properties#46 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_da.properties#47 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_de.properties#46 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_en_AU.properties#39 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_en_GB.properties#39 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_es.properties#46 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_eu.properties#3 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_fr.properties#48 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_fr_CA.properties#6 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_hi.properties#42 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_hu.properties#17 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_it.properties#47 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_ko.properties#45 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_ms.properties#11 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_nl.properties#45 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_pl.properties#46 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_pt.properties#12 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_pt_BR.properties#44 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_ro.properties#17 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_ru.properties#48 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_sl.properties#6 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_sv.properties#45 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_th.properties#14 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_tr.properties#43 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_uk.properties#16 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_zh_CN.properties#48 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_zh_HK.properties#45 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/keys/ZmKeys_zh_TW.properties#9 integrate
Change 533906 by dchristiansen@dchristiansen-box-2 on 2015/01/14 
	02:54:28

	bug 97249 - never tab to non-visible elements
	
	This ensures that DwtTabGroup takes Z-index and location into
	consideration when determining which elements are 'enabled'. Ideally,
	we'd only have actually, properly visible controls in the tab order,
	but that's just too invasive a change; instead, we consider the usual
	means for 'hiding' controls.
	
	The means for obtaining the Z-index is a bit round-about, as it isn't
	actually inherited; instead, we walk up the DOM tree.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97249

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/core/Dwt.js#9 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtTabGroup.js#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtControl.js#9 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/package/UnitTest.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/unittest/UtDwt.js#1 add
Change 534022 by dchristiansen@dchristiansen-box-2 on 2015/01/15 
	03:08:25

	bug 97249 - use Dwt-style instance checking in DwtTabGroup
	
	Previously, we used the instanceof operator both for checking against
	DwtControl and DwtTabGroup itself.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97249

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtTabGroup.js#8 edit
Bug 97272
Search toolbar tab order
Change 533908 by dchristiansen@dchristiansen-box-2 on 2015/01/14 
	03:00:08

	bug 97272 - fix search toolbar order
	
	The easiest way to fix this is to ensure that the controls have the
	expected order in the Dwt widget hierarchy.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97272

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/controller/ZmSearchController.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmSearchToolBar.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmToolBar.js#3 edit
Bug 97316
membership in many domain admin DLs causes slow domain admin login and management access
Change 536180 by heswaran@heswaran on 2015/02/04 15:13:58

	Bug: 97316
	
	1. GetAccountMembershipRequest is fired synchronously in a batch 
	request during the initial page load causing the delay in admin 
	console rendering. This request is made asynchronous to make the 
	initial rendering faster.
	2. SearchDirectoryRequest used for getting the number of Class of 
	Service is also converted to asynchronous call.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97316

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraAdmin/accounts/model/ZaAccount.js#390 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraAdmin/accounts/view/ZaAccountMemberOfListView.js#64 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraAdmin/common/ZaApp.js#156 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraAdmin/home/model/ZaHome.js#28 edit
Change 536480 by heswaran@heswaran on 2015/02/09 11:48:00

	Bug: 97316
	
	Synchronous SearchDirectoryRequest, which is used for getting the 
	domain list from the server, is modified as per the following.
	
	1. SearchDirectoryRequest is converted to asynchronous.
	2. Called during application launch.
	3. Search limit reduced to 25 from 100 for delegated admin accounts 
	for better server response. 
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97316

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraAdmin/common/ZaApp.js#157 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraAdmin/common/ZaController.js#168 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraAdmin/domains/model/ZaDomain.js#244 edit
Bug 97329
More accessibility fixes
Change 534195 by cdamon@cdamon_judaspriest on 2015/01/15 19:12:47

	Bug: 97329 - More accessibility fixes
	
	- Give DwtSelect a role of "combobox"
	- In conv view, give each msg iframe a title with
	msg number and conv subject
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtSelect.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmConvView2.js#15 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmMailMsgView.js#9 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#21 edit
Change 534397 by cdamon@cdamon_judaspriest on 2015/01/17 16:39:03

	Bug: 97329 - More accessibility fixes
	
	Address the following issues found by accessibility testing:
	
	2. Folder Properties dialog: "Properties" and "Retention" tabs don't 
	have proper ARIA roles; arrow keys don't move tab focus
	8. Share dialog: radio groups not labelled
	9. Share dialog: address field not labelled
	10. Folder Properties dialog: name field not labelled
	11. Folder Properties dialog: controls in Retention tab are not 
	labelled
	12. Rename Folder dialog: name field not labelled
	15. Folder info in hover tooltip not available
	
	
	- In dialogs, make sure that controls (such as INPUT or
	SELECT) have labels.
	- Center dialog title
	- Change DwtListView role from 'tree' to 'list'. Change
	role of its rows from 'treeitem' to 'listitem'. ZmConvListView
	overrides to use 'tree' and 'treeitem' since its rows are
	expandable.
	- Update DwtPropertySheet to use ARIA-style labels
	- Have DwtTabView use roles of 'tablist', 'tab', and 'tabpanel'
	for the tab view, tab button, and tab page respectively.
	- Give capsule msg view (in conv view) IFRAME a title
	- Add an action to the folder menu to show the folder info
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/css/dwt.css#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtListView.js#10 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtPropertySheet.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtTabView.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/core/ZmId.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/core/ZmOperation.js#9 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmConvListView.js#11 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmConvView2.js#16 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/controller/ZmFolderTreeController.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmDialog.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderPropertyView.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmSharePropsDialog.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#22 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/templates/share/Dialogs.template#2 edit
Change 534532 by cdamon@cdamon_judaspriest on 2015/01/19 16:59:48

	Bug: 97329 - More accessibility fixes
	
	Instead of having a new action to show folder stats,
	add it to the Folder Properties dialog as suggested by Dan.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/core/ZmId.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/core/ZmOperation.js#10 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/controller/ZmFolderTreeController.js#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderPropertyView.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#24 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/templates/share/App.template#2 edit
Change 534664 by cdamon@cdamon_judaspriest on 2015/01/20 18:52:18

	Bug: 97329 - More accessibility fixes
	
	Fix some tabbing issues with property sheets. The main issue
	was a lack of synchronization between the visibility of property
	values and their associated tab stops. Also, redo how visibility
	of a property is set. The old way removed the row and reshuffled
	the children, sometimes leaving empty or misordered rows. It was
	probably done that way because setting "display=none" on a TR
	had problems a long time ago. Seems to work fine now, and it's
	much simpler.
	
	- Don't tab to a tab group member that has zero size.
	
	- In folder tooltip and properties, show info as
	items, unread, size instead of having unread first.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtTabGroup.js#9 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtPropertySheet.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderPropertyView.js#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/templates/share/App.template#3 edit
Change 534676 by dchristiansen@dchristiansen-box-2 on 2015/01/21 
	02:21:35

	bug 97329 - don't dump tab groups to console by default
	
	I previously made it so that we also logged the output of
	DwtTabGroup::dump() to the console in addition to logging it in the
	debug window. Combined with the fact that dump the tab group tabbing
	to the next widget, this lead to unintentional and frequent console
	logging.
	
	Instead, we override dump() to only log to the console in the absence
	of a specified debugLevel. In addition, I overhauled the output to be
	slightly more readable by making the indentations a bit clearer.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtKeyboardMgr.js#9 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtTabGroup.js#10 edit
Change 535024 by dchristiansen@dchristiansen-box-2 on 2015/01/23 
	03:01:51

	bug 97329 - actually hide & show menus, rather than using z-index
	
	This causes VoiceOver to play a cute audio notification when popping
	up the menu. Provided we show the menu prior to rendering it,
	everything continues to work as expected.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMenu.js#6 edit
Change 535162 by cdamon@cdamon_judaspriest on 2015/01/24 17:52:28

	Bug: 97329 - More accessibility fixes
	
	Checkpoint for a bunch of miscellaneous accessibility fixes, mostly
	for the folder-related dialogs.
	
	- Add convenience methods to DwtControl for {get,set,remove}Attribute
	
	- Fix DwtPropertySheet bug that was causing error in Firefox, where
	we were needlessly calling _makeFocusable() on a value that's a
	DwtControl. That also had the undesirable side effect of adding it
	as a tab stop.
	
	- Remove role of 'combobox' for ZmAddressInputField since that
	prevents screen readers from properly recognizing the child TEXTAREA
	
	- Make sure tabs in ZmTabView correctly set 'aria-selected'
	
	- Remove role of 'listbox' for native SELECTs in dialogs
	
	- Return DwtSelect to a role of 'button'. Make sure it set
	'aria-haspopup' to true.
	
	- Move setting of aria-label up from DwtButton to DwtLabel so
	that DwtSelect gets it
	
	- Remove aria-labelledby from inner SPAN and INPUT of Name value
	in folder props dialog since it is in containing DIV
	
	- In New Folder dialog, give color button text alternative
	of "Color [color]"
	
	- Make a few fixes to the login page
	
	- Set aria-hidden to true on test IFRAME used to parse message
	HTML content
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtBaseDialog.js#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtButton.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtControl.js#12 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtGrouper.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtLabel.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtListView.js#11 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtPropertySheet.js#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtSelect.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtTabView.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtTreeItem.js#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/util/AjxStringUtil.js#9 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmConvListView.js#12 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmConvView2.js#20 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmMailMsgListView.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmAddressInputField.js#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmAppChooser.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmColorButton.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmOverview.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmShareReply.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderPropertyView.js#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmFolderRetentionView.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmNewOrganizerDialog.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmSharePropsDialog.js#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#16 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#26 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/public/login.jsp#8 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/skins/harmony/skin.properties#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/templates/share/Dialogs.template#3 edit
Change 535247 by cdamon@cdamon_judaspriest on 2015/01/26 16:36:14

	Bug: 97329 - More accessibility fixes
	
	- Fix focus of Feed URL INPUT in new folder dialog
	
	- Improve ALT text for Unknown Person contact image
	
	- Set 'aria-hidden=true' on the hidden keyboard focus
	field so that AT ignores it.
	
	- Set role of 'region' for msg view in reading pane
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtKeyboardMgr.js#10 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtButton.js#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtControl.js#13 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtLabel.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMenu.js#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMenuItem.js#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtSelect.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/controller/ZmComposeController.js#18 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmMailMsgView.js#11 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmShareReply.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmNewOrganizerDialog.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/dialog/ZmSharePropsDialog.js#8 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#27 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/templates/mail/Message.template#8 edit
Change 535614 by cdamon@cdamon_judaspriest_860 on 2015/01/29 19:28:54

	Bug: 97329 - More accessibility fixes
	
	Fix tabbing and focus issues with contact picker.
	
	- When detailed search is enabled, make sure to add
	all the search fields to the tab order.
	
	- Give each search field an aria-label.
	
	- Fix list view tabbing within chooser. We need to
	add each list view control to the tab order, not
	its rows container.
	
	- Add DwtListView:getEnabled(), which returns true
	if the list has at least one item. That's to prevent
	trying to tab to an empty list.
	
	- For compose input fields, provide a somewhat more
	descriptive label ("To address" instead of just "To").
	
	- Make the X that removes an attachment focusable, and
	have it react to Enter as well as click.
	
	- Fix problem with missing rowId in attachment data.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtChooser.js#3 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtListView.js#7 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/zimbraMail/abook/view/ZmContactPicker.js#3 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmComposeView.js#6 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmRecipients.js#4 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#13 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/templates/abook/Contacts.template#2 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/templates/mail/Message.template#7 edit
Change 535733 by cdamon@cdamon_judaspriest_860 on 2015/01/30 15:10:41

	Bug: 97329 - More accessibility fixes
	
	A few more accesibility fixes.
	
	- Set aria-hidden on tree item child DIV when
	tree item is collapsed.
	
	- Give a label to editor body area, whether it's
	a TEXTAREA (text mode) or a BODY (HTML mode)
	
	- Call proper parent method in DwtListView.getEnabled()
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtListView.js#8 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtTreeItem.js#5 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#11 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#14 edit
Change 536411 by cdamon@cdamon_judaspriest on 2015/02/07 19:46:22

	Bug: 97329 - More accessibility fixes
	
	- Mark table in banner area as presentational
	- Improve the alternative text for the search menu button
	- Give the search INPUT a text alternative
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtInputField.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/core/ZmZimbraMail.js#11 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/controller/ZmSearchController.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmSearchToolBar.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#32 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/skins/_base/base3/skin.html#2 edit
Change 536855 by cdamon@cdamon_judaspriest_860 on 2015/02/11 21:32:59

	Bug: 97329 - More accessibility fixes
	
	Accessibility fixes based on preliminary testing before the
	authoring of the WCAG statement.
	
	- Provide text alternative for "Show names from" select
	in contact picker
	- Provide label for URL field in new folder dialog
	- Remove aria-describedby from dialog. Don't set
	role=document for its content.
	- When a message dialog pops up, set aria-describedby
	for the button that gets initial focus
	- For a select, add ID of selected item to its aria-labelledby
	- Don't manage aria-hidden in selects
	- Include email with name when describing autocomplete match
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97329

Affected files ...

... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtBaseDialog.js#7 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMessageDialog.js#4 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtSelect.js#5 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/zimbraMail/abook/view/ZmContactPicker.js#4 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmAutocompleteListView.js#5 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#16 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/templates/abook/Contacts.template#3 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/templates/share/Dialogs.template#4 edit
Bug 97365
Dialog titles are centered
Change 534492 by cdamon@cdamon_judaspriest on 2015/01/19 13:08:40

	Bug: 97365 - Dialog titles are centered
	
	Remove centering style for dialog title
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97365

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/css/dwt.css#5 edit
Bug 97368
INVALID_ATTR_VALUE while adding external caldav calendar
Change 537149 by ryadav@ryadav_imac on 2015/02/15 22:00:26

	Bug 97368 - INVALID_ATTR_VALUE while adding external caldav calendar
	
	Changeset
	1. ZmCalendarTreeController.js
	
	Using AjxStringUtil.parseURL to parse the url. Default parameters 
	will be used for missing url components.
	Also added the new google url "apidata.googleusercontent.com" to 
	update the check for non google urls.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97368

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/controller/ZmCalendarTreeController.js#6 edit
Change 537150 by ryadav@ryadav_imac on 2015/02/15 22:03:02

	Merging using JUDASPRIEST_to_main
	
	Change 537149 by ryadav@ryadav_imac on 2015/02/15 22:00:26
	
		Bug 97368 - INVALID_ATTR_VALUE while adding external caldav calendar
	
		Changeset
		1. ZmCalendarTreeController.js
	
		Using AjxStringUtil.parseURL to parse the url. Default parameters 
		will be used for missing url components.
		Also added the new google url "apidata.googleusercontent.com" to 
		update the check for non google urls.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97368

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/controller/ZmCalendarTreeController.js#126 integrate
Change 537151 by ryadav@ryadav_imac on 2015/02/15 22:33:30

	Bug 97368 - INVALID_ATTR_VALUE while adding external caldav calendar
	
	Changeset:
	1. ZmCalendarTreeController.js
	
	Adding GOOGLE_CALDAV_SERVER constant to pickup the google server 
	string from here instead of the properties file.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97368

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/controller/ZmCalendarTreeController.js#7 edit
Change 537152 by ryadav@ryadav_imac on 2015/02/15 22:35:15

	Merging using JUDASPRIEST_to_main
	Change 537151 by ryadav@ryadav_imac on 2015/02/15 22:33:30
	
		Bug 97368 - INVALID_ATTR_VALUE while adding external caldav calendar
	
		Changeset:
		1. ZmCalendarTreeController.js
	
		Adding GOOGLE_CALDAV_SERVER constant to pickup the google server 
		string from here instead of the properties file.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97368

Affected files ...

... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/controller/ZmCalendarTreeController.js#127 integrate
Bug 97454
Script Error: a.addEventListener is not a function. Unable to share folder.
Change 534979 by cdamon@cdamon_judaspriest on 2015/01/22 15:25:00

	Bug: 97454 - Script Error: a.addEventListener is not a function. 
	Unable to share folder.
	
	Call _makeFocusable() directly on the control.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97454

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtPropertySheet.js#5 edit
Bug 97626
French localization errors under Affichage [Menu]
Bug 97636
App tab does not respond to Enter
Change 536090 by cdamon@cdamon_judaspriest on 2015/02/04 01:49:50

	Bug: 97636 - App tab does not respond to Enter
	
	The small fix for this is to remove ZmAppButton.getKeyMapName().
	That was returning the name "ZmAppButton", which is not a map we
	use. Due to that, the key action was being handled by the parent
	toolbar, which loses track of which of its buttons is focused when
	Tab is used to move among the buttons. We sidestep that problem
	by letting the button handle the key action.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97636

Affected files ...

... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtTabGroup.js#11 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmAppButton.js#4 edit
Bug 97652
Sometimes cannot type in Start/End Time fields
Bug 97739
Admin console shows JS error on startup
Change 536546 by cdamon@cdamon_judaspriest_860 on 2015/02/09 17:19:00

	Bug: 97739 - Admin console shows JS error on startup
	
	Make sure AjxUtil.isHash() can handle a missing arg.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97739

Affected files ...

... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/ajax/util/AjxUtil.js#4 edit
Bug 97758
Empty Trash option missing for Right click Trash folder in Mail tab
Change 536966 by cdamon@cdamon_judaspriest_860 on 2015/02/12 13:09:45

	Bug: 97758 - Empty Trash option missing for Right click Trash folder 
	in Mail tab
	
	Restore the full list of folder actions to the menu.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=97758

Affected files ...

... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/js/zimbraMail/share/controller/ZmFolderTreeController.js#4 edit
Bug 98044
8.6.0 patch 1 installation error on FOSS
Change 538072 by tpubliski@katbert on 2015/02/25 11:58:26

	Bug: 98044
	
	Update patch to only install zimbraews.jar if the system is NE.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=98044

Affected files ...

... //depot/zimbra/JUDASPRIEST-860/ZimbraBuild/rpmconf/Patch/conf/zmpatch.xml#5 edit
Change 538118 by tpubliski@katbert on 2015/02/25 17:31:31

	Bug: 98044
	
	Fix zimlet so that it deploys itself, rather than requiring manual 
	intervention.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=98044

Affected files ...

... //depot/zimbra/JUDASPRIEST-860/ZimbraBuild/rpmconf/Patch/conf/zmpatch.xml#6 edit
Change 538120 by tpubliski@katbert on 2015/02/25 17:36:50

	Bug: 98044
	
	Check if file type property is defined prior to evaluating it.
	
	https://bugzilla.zimbra.com/show_bug.cgi?id=98044

Affected files ...

... //depot/zimbra/JUDASPRIEST-860/ZimbraBuild/rpmconf/Patch/bin/zmpatch.pl#2 edit

Try Zimbra

Try Zimbra Collaboration with a 60-day free trial.
Get it now »

Want to get involved?

You can contribute in the Community, Wiki, Code, or development of Zimlets.
Find out more. »

Looking for a Video?

Visit our YouTube channel to get the latest webinars, technology news, product overviews, and so much more.
Go to the YouTube channel »

Jump to: navigation, search