Bug 71695 | Emptying the trash via IMAP should move the emptied messages to the Dumpster |
Change 535020 by pathakc@pathakc_mac on 2015/01/23 02:52:30
Bug:71695
Once Expunge occurs, mail item moves to mail_item_dumpster table.
But because of the \Deleted flag set for the item, it does not
appear to be recovered.
So deducted the \Deleted flag value(by bitwise operation) while
moving to mail_item_dumpster table. This happens only when Expunge
event occurs.
https://bugzilla.zimbra.com/show_bug.cgi?id=71695
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java-test/com/zimbra/cs/db/HSQLDB.java#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/Db.java#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/DbMailItem.java#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/MySQL.java#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/SQLite.java#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/imap/ImapHandler.java#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/mailbox/MailItem.java#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/mailbox/Mailbox.java#10 edit |
Change 535029 by pathakc@pathakc_mac on 2015/01/23 03:15:08
Bug:71695
Once Expunge occurs, mail item moves to mail_item_dumpster table.
But because of the \Deleted flag set for the item, it does not
appear to be recovered.
So deducted the \Deleted flag value(by bitwise operation) while
moving to mail_item_dumpster table. This happens only when Expunge
event occurs.
https://bugzilla.zimbra.com/show_bug.cgi?id=71695
Affected files ...
... //depot/zimbra/main/ZimbraServer/src/java-test/com/zimbra/cs/db/HSQLDB.java#17 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/Db.java#58 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/DbMailItem.java#302 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/MySQL.java#44 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/SQLite.java#57 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/imap/ImapHandler.java#384 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/mailbox/MailItem.java#325 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/mailbox/Mailbox.java#1022 integrate |
Change 535057 by psurana@psurana-mac on 2015/01/23 07:56:16
Bug:71695
Back out changelist 535020
https://bugzilla.zimbra.com/show_bug.cgi?id=71695
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java-test/com/zimbra/cs/db/HSQLDB.java#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/Db.java#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/DbMailItem.java#6 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/MySQL.java#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/SQLite.java#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/imap/ImapHandler.java#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/mailbox/MailItem.java#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/mailbox/Mailbox.java#11 edit |
Change 535058 by psurana@psurana-mac on 2015/01/23 07:57:18
Bug:71695
Back out changelist 535029
https://bugzilla.zimbra.com/show_bug.cgi?id=71695
Affected files ...
... //depot/zimbra/main/ZimbraServer/src/java-test/com/zimbra/cs/db/HSQLDB.java#18 edit
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/Db.java#59 edit
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/DbMailItem.java#303 edit
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/MySQL.java#45 edit
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/SQLite.java#58 edit
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/imap/ImapHandler.java#385 edit
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/mailbox/MailItem.java#326 edit
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/mailbox/Mailbox.java#1023 edit |
Change 535680 by pathakc@pathakc_mac on 2015/01/30 06:27:49
Bug:71695
Once Expunge occurs, mail item moves to mail_item_dumpster table.
But because of the \Deleted flag set for the item, it does not
appear to be recovered.
So deducted the \Deleted flag value(by bitwise operation) while
moving to mail_item_dumpster table. This happens only when Expunge
event occurs.
JUnit test TagTest is edited, as BITANDNOT() is not supported with
current HSQLDB v2.2.1. This can be uncommented once the HSQLDB is
upgraded to >= v2.2.6
https://bugzilla.zimbra.com/show_bug.cgi?id=71695
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java-test/com/zimbra/cs/db/HSQLDB.java#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java-test/com/zimbra/cs/mailbox/TagTest.java#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/Db.java#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/DbMailItem.java#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/MySQL.java#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/SQLite.java#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/imap/ImapHandler.java#8 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/mailbox/Mailbox.java#12 edit |
Change 535687 by pathakc@pathakc_mac on 2015/01/30 06:47:33
Bug:71695
Once Expunge occurs, mail item moves to mail_item_dumpster table.
But because of the \Deleted flag set for the item, it does not
appear to be recovered.
So deducted the \Deleted flag value(by bitwise operation) while
moving to mail_item_dumpster table. This happens only when Expunge
event occurs.
JUnit test TagTest is edited, as BITANDNOT() is not supported with
current HSQLDB v2.2.1. This can be uncommented once the HSQLDB is
upgraded to >= v2.2.6
https://bugzilla.zimbra.com/show_bug.cgi?id=71695
Affected files ...
... //depot/zimbra/main/ZimbraServer/src/java-test/com/zimbra/cs/db/HSQLDB.java#19 integrate
... //depot/zimbra/main/ZimbraServer/src/java-test/com/zimbra/cs/mailbox/TagTest.java#19 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/Db.java#61 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/DbMailItem.java#306 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/MySQL.java#47 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/SQLite.java#60 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/imap/ImapHandler.java#386 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/mailbox/Mailbox.java#1027 integrate |
Bug 74953 | mail items deleted by IMAP and not expunged can cause performance issues |
Change 538990 by pathakc@pathakc_mac on 2015/03/09 03:02:49
Bug: 74953
Cleanup - imap deleted mail items.
- Using attribute zimbraMailTrashLifetime with default value as 30d.
- Within Mailbox.purgeMessages(), find and delete mail items with
"\Deleted" flag and changed date is old enough.
- Added couple of unit tests in PurgeTest.
https://bugzilla.zimbra.com/show_bug.cgi?id=74953
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java-test/com/zimbra/cs/mailbox/PurgeTest.java#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/DbMailItem.java#10 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/mailbox/Mailbox.java#13 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/qa/unittest/TestUtil.java#5 edit |
Change 538993 by pathakc@pathakc_mac on 2015/03/09 04:43:08
Bug: 74953
Cleanup - imap deleted mail items.
- Using attribute zimbraMailTrashLifetime with default value as 30d.
- Within Mailbox.purgeMessages(), find and delete mail items with
"\Deleted" flag and changed date is old enough.
- Added couple of unit tests in PurgeTest.
https://bugzilla.zimbra.com/show_bug.cgi?id=74953
Affected files ...
... //depot/zimbra/main/ZimbraServer/src/java-test/com/zimbra/cs/mailbox/PurgeTest.java#16 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/DbMailItem.java#310 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/mailbox/Mailbox.java#1032 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/qa/unittest/TestUtil.java#161 integrate |
Bug 84629 | Enhancement request to add LC value for WAITSET_TIMEOUT |
Change 546279 by psurana@psurana-mac on 2015/06/02 07:35:52
bug:84629
Added LC key "zimbra_active_waitset_timeout_minutes"
Timeout active waitset thread those are not updated within timeout
limit. Default 20 mins
https://bugzilla.zimbra.com/show_bug.cgi?id=84629
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraCommon/src/java/com/zimbra/common/localconfig/LC.java#12 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/session/WaitSetMgr.java#2 edit |
Bug 91316 | Calendar location truncated with room and phone number |
Change 536487 by vbellows@vbellows-JP on 2015/02/09 11:56:10
Bug: 91316 - Calendar location truncated with room and phone number
It looks like we've supported either attendees or free-form info in
the location field, but not both. This CL will:
- Show the calItem.location for the read-only view (attendees
viewing the appt). That includes the non-attendee info.
- Show the non-attendee info appended to the location attendee list
for the organizer, when they open the appt.
It also eliminates the call to the ZmApptEditView._setAttendees from
ZmApptEditView.show. ZmApptComposeView.set calls populateForEdit,
which formats the attendees. That was being followed by a call to
ZmApptEditView.show, where _setAttendees was called, clearing the
attendee info and redoing it.
https://bugzilla.zimbra.com/show_bug.cgi?id=91316
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/view/ZmApptEditView.js#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/view/ZmCalItemView.js#2 edit |
Change 536490 by vbellows@vbellows-main on 2015/02/09 11:58:51
Bug: 91316 - Calendar location truncated with room and phone number
It looks like we've supported either attendees or free-form info in
the location field, but not both. This CL will:
- Show the calItem.location for the read-only view (attendees
viewing the appt). That includes the non-attendee info.
- Show the non-attendee info appended to the location attendee list
for the organizer, when they open the appt.
It also eliminates the call to the ZmApptEditView._setAttendees from
ZmApptEditView.show. ZmApptComposeView.set calls populateForEdit,
which formats the attendees. That was being followed by a call to
ZmApptEditView.show, where _setAttendees was called, clearing the
attendee info and redoing it.
Merging
//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/cale
ndar/view/...
to
//depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/vi
ew/...
https://bugzilla.zimbra.com/show_bug.cgi?id=91316
Affected files ...
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/view/ZmApptEditView.js#307 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/view/ZmCalItemView.js#84 integrate |
Bug 95414 | Windows RT - IE defaults to Mobile client interface |
Change 536586 by kkakani@kkakani_new on 2015/02/10 02:37:19
bug:95414 - Windows RT - IE defaults to Mobile client interface
-While parsing the user agent string check for the specific windows
OS.
-Introduced two booleans, isWindowsNT and isWindowsPhone.
-In case of Windows, redirect to mobile interface only if
isWindowsPhone is true.
https://bugzilla.zimbra.com/show_bug.cgi?id=95414
Affected files ...
... //depot/zimbra/main/ZimbraTagLib/src/java/com/zimbra/cs/taglib/bean/ZUserAgentBean.java#31 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/public/login.jsp#200 edit |
Change 536587 by kkakani@kkakani_new on 2015/02/10 02:41:16
Integrate the following change from main to JP
Change 536586 by kkakani@kkakani_new on 2015/02/10 02:37:19
bug:95414 - Windows RT - IE defaults to Mobile client interface
-While parsing the user agent string check for the specific windows
OS.
-Introduced two booleans, isWindowsNT and isWindowsPhone.
-In case of Windows, redirect to mobile interface only if
isWindowsPhone is true.
https://bugzilla.zimbra.com/show_bug.cgi?id=95414
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraTagLib/src/java/com/zimbra/cs/taglib/bean/ZUserAgentBean.java#2 integrate
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/public/login.jsp#9 integrate |
Change 541830 by tpubliski@katbert on 2015/04/10 12:02:14
Bug: 95414,98773
Back out Change 541387.
https://bugzilla.zimbra.com/show_bug.cgi?id=95414
https://bugzilla.zimbra.com/show_bug.cgi?id=98773
Affected files ...
... //depot/zimbra/JUDASPRIEST-860/ZimbraTagLib/src/java/com/zimbra/cs/taglib/bean/ZUserAgentBean.java#3 edit
... //depot/zimbra/JUDASPRIEST-860/ZimbraWebClient/WebRoot/public/login.jsp#6 edit |
Change 543357 by kkakani@kkakani_new on 2015/04/29 05:37:34
bug:95414 - Windows RT - IE defaults to Mobile client interface
-Fix the condition which decides whether mobile client is supported
for a given user-agent string.
https://bugzilla.zimbra.com/show_bug.cgi?id=95414
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraTagLib/src/java/com/zimbra/cs/taglib/bean/ZUserAgentBean.java#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/public/login.jsp#10 edit |
Change 543358 by kkakani@kkakani_new on 2015/04/29 05:39:20
Integrate the following change from JP to main
Change 543357 by kkakani@kkakani_new on 2015/04/29 05:37:34
bug:95414 - Windows RT - IE defaults to Mobile client interface
-Fix the condition which decides whether mobile client is supported
for a given user-agent string.
https://bugzilla.zimbra.com/show_bug.cgi?id=95414
Affected files ...
... //depot/zimbra/main/ZimbraTagLib/src/java/com/zimbra/cs/taglib/bean/ZUserAgentBean.java#32 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/public/login.jsp#201 integrate |
Bug 96516 | Failure in syncing local filtered messages from Mobile |
Change 543475 by sprasad@sprasad on 2015/04/30 05:26:39
Bug: 96516 - Failure in syncing local filtered messages from Mobile
The filtered messages were not synced because they were sent in sync
response as âChange' command instead of âAddâ to target
folder. Reason for change command was the missing prevFolder for
these mailItems. When filter is run on web client, filtering logic
copies the mails to target folder and then deletes original mails
from source folder. But it doesnât populate the prevFolder in new
mailItems.To fix this added logic to populate the prevFolder during
mailbox copy operation.
Tested the scenario mentioned in bug.Also tested if relevant mail
from Trash/Junk folders are also filtered to target folder if these
folders are selected while running the filter.
https://bugzilla.zimbra.com/show_bug.cgi?id=96516
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java-test/com/zimbra/cs/filter/ExistingMessageHandlerTest.java#1 add
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/DbMailItem.java#12 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/filter/ExistingMessageHandler.java#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/mailbox/MailItem.java#5 edit |
Change 543480 by sprasad@sprasad on 2015/04/30 05:39:03
Merging
//depot/zimbra/JUDASPRIEST/...
to //depot/zimbra/main/...
Change 543475 by sprasad@sprasad on 2015/04/30 05:26:39
Bug: 96516 - Failure in syncing local filtered messages from Mobile
The filtered messages were not synced because they were sent in
sync
response as âÂÂChange' command instead of âÂÂAddâ to
target
folder. Reason for change command was the missing prevFolder for
these mailItems. When filter is run on web client, filtering logic
copies the mails to target folder and then deletes original mails
from source folder. But it doesnâÂÂt populate the prevFolder in
new
mailItems.To fix this added logic to populate the prevFolder during
mailbox copy operation.
Tested the scenario mentioned in bug.Also tested if relevant mail
from Trash/Junk folders are also filtered to target folder if these
folders are selected while running the filter.
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java-test/com/zimbra/cs/filter/ExistingMessageHandlerTest.java#1 add
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/db/DbMailItem.java#12 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/filter/ExistingMessageHandler.java#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/mailbox/MailItem.java#5 edit
https://bugzilla.zimbra.com/show_bug.cgi?id=96516
Affected files ...
... //depot/zimbra/main/ZimbraServer/src/java-test/com/zimbra/cs/filter/ExistingMessageHandlerTest.java#1 branch
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/db/DbMailItem.java#312 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/filter/ExistingMessageHandler.java#27 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/mailbox/MailItem.java#332 integrate |
Bug 96734 | Setting time zone for COS to 'GMT +02:00 Harare, Pretoria' in admin console throws an error |
Change 535227 by gren.elliot@gelliot_coco on 2015/01/26 13:30:30
bug: 96734
Stop timezones from being referenced twice in timezones.ics - once
as a TZID and once as X-ZIMBRA-TZ-ALIAS
Selecting "Harare, Pretoria" as the timezone preference for a COS in
Admin Console result in a confusing error message:
The current time zone "Africa/Maputo" for cos - "default" is
invalid, please go to Preferences to set the valid time zone.
although accounts created with this COS do get the timezone
Africa/Maputo (which has the same rules as Africa/Harare)
After this change, the COS timezone gets set to "Africa/Harare"
which is more appropriate and no error message is shown.
https://reviewboard.eng.zimbra.com/r/3860/
https://bugzilla.zimbra.com/show_bug.cgi?id=96734
Affected files ...
... //depot/zimbra/main/ZimbraCommon/ZimbraStoreCommon/src/main/java/com/zimbra/common/calendar/ZoneInfo2iCalendar.java#2 edit
... //depot/zimbra/main/ZimbraServer/conf/timezones.ics#24 edit |
Change 535239 by gren.elliot@gelliot_coco on 2015/01/26 14:28:49
bug: 96734
Stop timezones from being referenced twice in timezones.ics - once
as a TZID and once as X-ZIMBRA-TZ-ALIAS
Selecting "Harare, Pretoria" as the timezone preference for a COS in
Admin Console result in a confusing error message:
The current time zone "Africa/Maputo" for cos - "default" is
invalid, please go to Preferences to set the valid time zone.
although accounts created with this COS do get the timezone
Africa/Maputo (which has the same rules as Africa/Harare)
After this change, the COS timezone gets set to "Africa/Harare"
which is more appropriate and no error message is shown.
https://reviewboard.eng.zimbra.com/r/3860/
main ---> JUDASPRIEST
https://bugzilla.zimbra.com/show_bug.cgi?id=96734
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraCommon/src/java/com/zimbra/common/calendar/ZoneInfo2iCalendar.java#3 integrate
... //depot/zimbra/JUDASPRIEST/ZimbraServer/conf/timezones.ics#6 integrate |
Change 546503 by gren.elliot@gelliot_JP on 2015/06/03 11:54:30
Bug: 96734
Latest timezones.ics file - mostly to fix issues with duplicate
timezone ID references
https://bugzilla.zimbra.com/show_bug.cgi?id=96734
Affected files ...
... //depot/zimbra/JUDASPRIEST-860/ZimbraServer/conf/timezones.ics#2 edit |
Bug 96847 | collapse/expand arrow is selecting the item in folder chooser dialog/drop-down |
Change 531695 by eyarkon@eyarkon-JUDASPRIEST on 2014/12/10 14:23:55
Bug 96847
collapse/expand arrow is selecting the item in folder chooser
dialog/drop-down
This deals with 2 issues:
1. The "Mail Folders" root/header in the search tab advanced filter
folder chooser dialog, should not be selectable. Easy fix in
ZmFolderSearchFilter.prototype._getMoveParams
2. the collapse/expand arrow should only do the collapse/expand, and
not do selection. For this I added a simple _expandable field to
DwtTreeItem to indicate if item is expandable (if it has children OR
some forceNode param, that I think is never passed, is true in
DwtTreeItem.prototype._initializ)
More importantly, since DwtTreeItem._nodeIconMouseDownHdlr takes
care of collapsing/expanding the node when clicking on the arrow, we
do not need to do anything in DwtTreeItem._mouseUpListener if the
click is ON the arrow. Thus checking for that case and exiting from
that method if that's the case.
https://bugzilla.zimbra.com/show_bug.cgi?id=96847
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtTreeItem.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/ZmSearchResultsFilterPanel.js#3 edit |
Bug 97552 | Editor Won't Accept Paste Image From Clipboard |
Change 539057 by vbellows@vbellows-JP on 2015/03/09 15:29:57
Bug: 97552 - Editor Won't Accept Paste Image From Clipboard
When the paste plugin is enabled, its editor.on('paste') handler
gets called, which contains:
// Not a keyboard paste, prevent default paste and try to grab the
clipboard contents using different APIs
if (!isKeyBoardPaste) {
e.preventDefault();
}
However, when Firefox copies an image, the image info is not
available via the clipboard - it can only be natively pasted inline,
and the 'preventDefault' stops that from occurring.
I've changed the test in the paste plugin s.t. it will only
preventDefault if its not a keyboard paste && (IE or there is
clipboard content)
Firefox, Chrome - OK
Safari - does not work, but looks to be an underlying webkit bug,
https://bugs.webkit.org/show_bug.cgi?id=75891, 'Safari fails to fire
paste events', reported for Safari 8 too.
IE11 - Continue to suppress the default; paste works, and if the
default is not suppressed, IE11 crashes.
https://bugzilla.zimbra.com/show_bug.cgi?id=97552
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/classes/Clipboard.js#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/plugin.js#2 edit |
Change 539060 by vbellows@vbellows-main on 2015/03/09 15:32:35
Bug: 97552 - Editor Won't Accept Paste Image From Clipboard
When the paste plugin is enabled, its editor.on('paste') handler
gets called, which contains:
// Not a keyboard paste, prevent default paste and try to grab the
clipboard contents using different APIs
if (!isKeyBoardPaste) {
e.preventDefault();
}
However, when Firefox copies an image, the image info is not
available via the clipboard - it can only be natively pasted inline,
and the 'preventDefault' stops that from occurring.
I've changed the test in the paste plugin s.t. it will only
preventDefault if its not a keyboard paste && (IE or there is
clipboard content)
Firefox, Chrome - OK
Safari - does not work, but looks to be an underlying webkit bug,
https://bugs.webkit.org/show_bug.cgi?id=75891, 'Safari fails to fire
paste events', reported for Safari 8 too.
IE11 - Continue to suppress the default; paste works, and if the
default is not suppressed, IE11 crashes.
Merging
//depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/
tinymce/plugins/paste/...
to
//depot/zimbra/main/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce
/plugins/paste/...
https://bugzilla.zimbra.com/show_bug.cgi?id=97552
Affected files ...
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/classes/Clipboard.js#2 integrate
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/plugin.js#2 integrate |
Bug 97672 | Lots of "Committed before 401 null" warnings in zmmailboxd.out |
Change 538218 by gren.elliot@gelliot_coco on 2015/02/26 15:53:28
Bug:97672
CalDAV/CardDAV clients behavior triggers Lots of "Committed before
401 null" warnings in zmmailboxd.out
A lot of DAV clients try an initial HTTP method call without
authentication to determine what auth schemes are in place.
Our servlet called sendError more than once when handling this.
https://reviewboard.eng.zimbra.com/r/4215/
https://bugzilla.zimbra.com/show_bug.cgi?id=97672
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/dav/service/DavServlet.java#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/servlet/ZimbraServlet.java#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/cs/servlet/util/AuthUtil.java#2 edit
... //depot/zimbra/JUDASPRIEST/ZimbraServer/src/java/com/zimbra/qa/unittest/TestCalDav.java#9 edit |
Change 538221 by gren.elliot@gelliot_coco on 2015/02/26 16:19:12
Bug:97672
CalDAV/CardDAV clients behavior triggers Lots of "Committed before
401 null" warnings in zmmailboxd.out
A lot of DAV clients try an initial HTTP method call without
authentication to determine what auth schemes are in place.
Our servlet called sendError more than once when handling this.
https://reviewboard.eng.zimbra.com/r/4215/
JUDASPRIEST ---> main
https://bugzilla.zimbra.com/show_bug.cgi?id=97672
Affected files ...
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/dav/service/DavServlet.java#76 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/servlet/ZimbraServlet.java#113 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/cs/servlet/util/AuthUtil.java#11 integrate
... //depot/zimbra/main/ZimbraServer/src/java/com/zimbra/qa/unittest/TestCalDav.java#18 integrate |
Bug 97792 | Not able to permanently delete messages from trash while in message view |
Change 541501 by kkakani@kkakani_new on 2015/04/07 04:54:05
bug:97792 - Not able to delete messages from trash in message view
-Handle permanent delete for messages.
https://bugzilla.zimbra.com/show_bug.cgi?id=97792
Affected files ...
... //depot/zimbra/main/ZimbraNetwork/ZimbraTouch/WebRoot/t/app/controller/mail/ZtConvItemController.js#7 edit
... //depot/zimbra/main/ZimbraNetwork/ZimbraTouch/WebRoot/t/app/controller/mail/ZtMailItemController.js#14 edit |
Change 541502 by kkakani@kkakani_new on 2015/04/07 04:56:58
Integrate the following change from main to JP
Change 541501 by kkakani@kkakani_new on 2015/04/07 04:54:05
bug:97792 - Not able to delete messages from trash in message view
-Handle permanent delete for messages.
https://bugzilla.zimbra.com/show_bug.cgi?id=97792
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraNetwork/ZimbraTouch/WebRoot/t/app/controller/mail/ZtConvItemController.js#7 integrate
... //depot/zimbra/JUDASPRIEST/ZimbraNetwork/ZimbraTouch/WebRoot/t/app/controller/mail/ZtMailItemController.js#10 integrate |
Bug 98327 | Outlook 2011 with EWS deletes shared contacts folder |
Change 544482 by psurana@psurana-mac on 2015/05/13 06:28:30
bug:98327
Outlook 2011 with EWS deletes shared contacts folder
Test #1:
1. create new address book user1.
2. Share the created address book with user2 with manager rights.
3. configure user2 with outlook 2011 using EWS
4. let it sync
5. From outlook right click the shared address book click "Remove
from View"
Verified Address book not deleted from user1 .
Test #2:
1. create new address book user1.
2. Share the created address book with DL in which user2 is member
with manager rights.
3. configure user2 with outlook 2011 using EWS
4. let it sync
5. From outlook right click the shared address book click "Remove
from View"
Verified Address book not deleted from user1 .
Test #3: QA multinode environment
Pre: User1 and user2 on different mail store.
1. create new address book user1.
2. Share the created address book with user2 with manager rights.
3. configure user2 with outlook 2011 using EWS
4. let it sync
5. From outlook right click the shared address book click "Remove
from View"
Verified Address book not deleted from user1 .
https://bugzilla.zimbra.com/show_bug.cgi?id=98327
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/operation/FolderOperation.java#11 edit |
Change 544483 by psurana@psurana-mac on 2015/05/13 06:31:59
bug:98327
Outlook 2011 with EWS deletes shared contacts folder
Test #1:
1. create new address book user1.
2. Share the created address book with user2 with manager rights.
3. configure user2 with outlook 2011 using EWS
4. let it sync
5. From outlook right click the shared address book click "Remove
from View"
Verified Address book not deleted from user1 .
Test #2:
1. create new address book user1.
2. Share the created address book with DL in which user2 is member
with manager rights.
3. configure user2 with outlook 2011 using EWS
4. let it sync
5. From outlook right click the shared address book click "Remove
from View"
Verified Address book not deleted from user1 .
Test #3: QA multinode environment
Pre: User1 and user2 on different mail store.
1. create new address book user1.
2. Share the created address book with user2 with manager rights.
3. configure user2 with outlook 2011 using EWS
4. let it sync
5. From outlook right click the shared address book click "Remove
from View"
Verified Address book not deleted from user1 .
https://bugzilla.zimbra.com/show_bug.cgi?id=98327
Affected files ...
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/operation/FolderOperation.java#44 integrate |
Bug 98420 | Unable to Paste an image from the clipboard into the html editor body using Ctrl-V |
Change 540752 by vbellows@vbellows-JP on 2015/03/30 14:35:08
Bug: 98420 - Unable to Paste an image from the clipboard into the
html editor body using Ctrl-V
Three problems:
1. There is a race condition with pasting the image via Ctrl-V; this
may only occur in a dev environment, but the fix shouldn't cause any
problems. The problem is:
- The paste plugin does a createPasteBin, creating a marker
element that it uses.
- We upload a pasted image.
- The upload completes, and we do a SaveDraft. It calls
insertImage.
- A timeout function from the plugin executes and calls
removePasteBin, before or after the insertImage call.
- InsertImage executes. If the pasteBin has not been removed
when we try to insert the image, it interferes with tinyMCE
insertion.
No image is inserted in the editor body, and we end up with
an attachment bubble instead.
2. For Firefox (which relies on its default paste event handling to
paste an image), Ctrl-V is being disrupted. It looks like when the
paste plugin does the createPasteBin call, it changes the element
focus and
selection; apparently that aborts the default image paste. The
createPasteBin should only be prevented for an image paste, when
there is no clipboard data. Otherwise (for text) paste is done twice.
3. For Safari, Ctrl-V ends up creating a 'webkit-fake-url' image; we
delete it on SaveDraft. See Bug 77567, " Safari copy/paste
screenshot in email sends blank image ".
https://bugzilla.zimbra.com/show_bug.cgi?id=98420
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#24 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/patches/10-clipboard-paste-ctrlv.diff#1 add
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/classes/Clipboard.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/plugin.dev.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/plugin.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/plugin.min.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.dev.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.jquery.dev.js#5 edit |
Change 540753 by vbellows@vbellows-main on 2015/03/30 14:40:20
Bug: 98420 - Unable to Paste an image from the clipboard into the
html editor body using Ctrl-V
Three problems:
1. There is a race condition with pasting the image via Ctrl-V; this
may only occur in a dev environment, but the fix shouldn't cause any
problems. The problem is:
- The paste plugin does a createPasteBin, creating a marker
element that it uses.
- We upload a pasted image.
- The upload completes, and we do a SaveDraft. It calls
insertImage.
- A timeout function from the plugin executes and calls
removePasteBin, before or after the insertImage call.
- InsertImage executes. If the pasteBin has not been removed
when we try to insert the image, it interferes with tinyMCE
insertion.
No image is inserted in the editor body, and we end up with
an attachment bubble instead.
2. For Firefox (which relies on its default paste event handling to
paste an image), Ctrl-V is being disrupted. It looks like when the
paste plugin does the createPasteBin call, it changes the element
focus and
selection; apparently that aborts the default image paste. The
createPasteBin should only be prevented for an image paste, when
there is no clipboard data. Otherwise (for text) paste is done twice.
3. For Safari, Ctrl-V ends up creating a 'webkit-fake-url' image; we
delete it on SaveDraft. See Bug 77567, " Safari copy/paste
screenshot in email sends blank image ".
Merging
//depot/zimbra/JUDASPRIEST/ZimbraWebClient/...
to //depot/zimbra/main/ZimbraWebClient/...
https://bugzilla.zimbra.com/show_bug.cgi?id=98420
Affected files ...
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#281 integrate
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/patches/10-clipboard-paste-ctrlv.diff#1 branch
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/classes/Clipboard.js#3 integrate
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/plugin.dev.js#3 integrate
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/plugin.js#3 integrate
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/plugin.min.js#3 integrate
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.dev.js#5 integrate
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/tinymce.jquery.dev.js#5 integrate |
Change 541037 by vbellows@vbellows-JP on 2015/04/01 14:06:06
Bug: 98420 - Unable to Paste an image from the clipboard into the
html editor body using Ctrl-V
The prior 'fix' caused more problems than it fixed- back the paste
plugin part of it out.
This leaves us with Ctrl-V not working for Firefox image paste (it
does have the right-click paste working).
https://bugzilla.zimbra.com/show_bug.cgi?id=98420
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/patches/10-clipboard-paste-ctrlv.diff#2 delete
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/classes/Clipboard.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/plugin.js#4 edit |
Change 541038 by vbellows@vbellows-main on 2015/04/01 14:08:55
Bug: 98420 - Unable to Paste an image from the clipboard into the
html editor body using Ctrl-V
The prior 'fix' caused more problems than it fixed- back the paste
plugin part of it out.
This leaves us with Ctrl-V not working for Firefox image paste (it
does have the right-click paste working).
Merging
//depot/zimbra/JUDASPRIEST/ZimbraWebClient/tiny_mce/...
to //depot/zimbra/main/ZimbraWebClient/tiny_mce/...
https://bugzilla.zimbra.com/show_bug.cgi?id=98420
Affected files ...
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/patches/10-clipboard-paste-ctrlv.diff#2 delete
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/classes/Clipboard.js#4 integrate
... //depot/zimbra/main/ZimbraWebClient/tiny_mce/tinymce-4.1.6/js/tinymce/plugins/paste/plugin.js#4 integrate |
Bug 98512 | Cursor remains or highlighted in Body instead of 'To' field from HTML Compose Window. |
Change 541272 by vbellows@vbellows-JP on 2015/04/03 13:43:51
Bug: 98512 - Cursor remains or highlighted in Body instead of 'To'
field from HTML Compose Window.
The problem occurs due to the fix for Bug 97956, "Firefox: first
reply after login loses cursor focus". The editor autofocus was set
to true when first created (causing focus to be moved to the editor
body), but it should not be true for new or forwarded messages
(where the focus should start in the 'To' field).
https://bugzilla.zimbra.com/show_bug.cgi?id=98512
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/docs/view/ZmDocsEditView.js#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/controller/ZmComposeController.js#25 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmComposeView.js#27 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/prefs/model/ZmPref.js#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#25 edit |
Change 541280 by vbellows@vbellows-main on 2015/04/03 14:30:41
Bug: 98512 - Cursor remains or highlighted in Body instead of 'To'
field from HTML Compose Window.
The problem occurs due to the fix for Bug 97956, "Firefox: first
reply after login loses cursor focus". The editor autofocus was set
to true when first created (causing focus to be moved to the editor
body), but it should not be true for new or forwarded messages
(where the focus should start in the 'To' field).
Merging
//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/...
to //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/...
https://bugzilla.zimbra.com/show_bug.cgi?id=98512
Affected files ...
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/docs/view/ZmDocsEditView.js#59 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/controller/ZmComposeController.js#544 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmComposeView.js#776 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/prefs/model/ZmPref.js#129 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#282 integrate |
Bug 98584 | Scroll bar goes crazy in Move Message dialog window |
Change 541942 by vbellows@vbellows-JP on 2015/04/13 09:49:27
Bug: 98584 - Scroll bar goes crazy in Move Message dialog window
It looks to be the same problem as Bug 97816, "Can not select text
from About zimbra version dailog", where focus gets hijacked in a
dialog. I'm pushing the 'ZmMessageDialog.isFocusable=false' down to
DwtBaseDialog. I tested what dialogs I could find, it doesn't seem
to cause any side effects.
https://bugzilla.zimbra.com/show_bug.cgi?id=98584
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtBaseDialog.js#8 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMessageDialog.js#6 edit |
Change 541944 by vbellows@vbellows-main on 2015/04/13 09:53:12
Bug: 98584 - Scroll bar goes crazy in Move Message dialog window
It looks to be the same problem as Bug 97816, "Can not select text
from About zimbra version dailog", where focus gets hijacked in a
dialog. I'm pushing the 'ZmMessageDialog.isFocusable=false' down to
DwtBaseDialog. I tested what dialogs I could find, it doesn't seem
to cause any side effects.
Merging
//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/ajax/dwt/widget
s/...
to
//depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/...
https://bugzilla.zimbra.com/show_bug.cgi?id=98584
Affected files ...
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtBaseDialog.js#32 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/widgets/DwtMessageDialog.js#34 integrate |
Bug 98786 | Returns stripped when composing in HTML via deep link |
Change 541769 by cdamon@cdamon_judaspriest on 2015/04/09 11:45:05
Bug: 98786 - Returns stripped when composing in HTML via deep link
Convert passed-in body text to HTML if composing as HTML.
https://bugzilla.zimbra.com/show_bug.cgi?id=98786
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/mail/view/ZmComposeView.js#28 edit |
Bug 98833 | EWS - Error in getFolder |
Change 544470 by psurana@psurana-mac on 2015/05/13 04:40:24
bug: 98833
Fixed Foldersync issues to accomocate alias or non existing email
address.
Code clean up and refactored.
Fixed possible NPE.
Tested.
1. Sync by configuring account with account name.
2. Sync by configuring account with account alias.
3. Sync by configuring account with valid credentials and non
existing email address.
4. Verified mounting shared folder with users account name.
5. Verified mounting shared folder with users alias name.
6. Verified no NPE mounting shared folder with non existing user.
https://bugzilla.zimbra.com/show_bug.cgi?id=98833
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/ews/service/FolderService.java#8 edit
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/ews/util/FolderUtil.java#4 edit
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/ews/util/ItemUtil.java#5 edit
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/operation/FolderOperation.java#10 edit |
Change 544471 by psurana@psurana-mac on 2015/05/13 04:41:35
bug: 98833
Fixed Foldersync issues to accomocate alias or non existing email
address.
Code clean up and refactored.
Fixed possible NPE.
Tested.
1. Sync by configuring account with account name.
2. Sync by configuring account with account alias.
3. Sync by configuring account with valid credentials and non
existing email address.
4. Verified mounting shared folder with users account name.
5. Verified mounting shared folder with users alias name.
6. Verified no NPE mounting shared folder with non existing user.
https://bugzilla.zimbra.com/show_bug.cgi?id=98833
Affected files ...
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/ews/service/FolderService.java#32 integrate
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/ews/util/FolderUtil.java#16 integrate
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/ews/util/ItemUtil.java#29 integrate
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/operation/FolderOperation.java#43 integrate |
Bug 98895 | Shift+tab is inconsistent ; different from using TAB |
Change 542908 by eyarkon@eyarkon-main on 2015/04/23 12:29:18
Bug 98895
Shift+tab is inconsistent ; different from using TAB
Let the keyboard manager handle tabs clicked inside the editor.
(that fixes both shift+tab and also tab from the editor, which was
also broken).
https://bugzilla.zimbra.com/show_bug.cgi?id=98895
Affected files ...
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#284 edit |
Change 543181 by eyarkon@eyarkon-main on 2015/04/27 18:41:10
Bug 98895
Shift+tab is inconsistent ; different from using TAB
Continuation of my previous fix from this bug (in the previous one,
I fixed the tabbing from the editor to actually do the correct ZWC
thing so we get correct focus - however, the shift+tab was skipping
the editor toolbar straight to the "attach" button, a minor issue
but this bug addresses it).
first thing I noticed that seemed pretty bad was that in
ZmHtmlEditor.prototype._setupTabGroup, we set the tab group to
include the editor (tinyMCE) toolbar as well as "this" (ZmHtmlEditor
object). This seems bad since it creates a sort of infinite
recursion in the tab structure. (Since ZmHtmlEditor includes
__tabGroup which included itself, and so on).
This first thing caused the shift+tab to skip the editor toolbar,
since the current focus item was the ZmHtmlEditor, which includes
the toolbar (we did not have a specific focus member for the editor
area itself). I fixed that by making the iframe body the focus
member for actual editing.
The second issue (tinymceEvent.bind in ZmHtmlEditor.prototype.onInit
was that at least after my above fix, if the user clicked inside the
editor area, and then tabbed, it was still tabbing from the previous
focus member. Fixed that by again focusing on the iframe body.
(Modified part of a fix to bug 32283)
https://bugzilla.zimbra.com/show_bug.cgi?id=98895
Affected files ...
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/ajax/dwt/keyboard/DwtTabGroup.js#36 edit
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/share/view/htmlEditor/ZmHtmlEditor.js#285 edit |
Bug 99179 | Modify recurring appointment - custom repeat shows incorrect values |
Change 544300 by vbellows@vbellows-JP on 2015/05/11 12:18:28
Bug: 99179 - Modify recurring appointment - custom repeat shows
incorrect values
The appt edit view is initialized from the appt (populateForEdit),
then saves back into the appt (populateForSave), but with
potentially incomplete information. Note, populateForSave is called
whenever the code needs the appointment to reflect the entries in
the appt edit view - upon an actual save, or when it pops up a
subdialog, such as the custom recurrence dialog.
I've modified it such that ZmCalItemEditView presents the 'Custom'
choice in the repeat dropdown when there is a custom recurrence
(which makes its consistent with what happens when you first create
a custom recurrence). Previously it would show the recurrence
period in the drop down (Daily, Weekly, etc), but not the fact that
it is custom - that was indicated only by the blurb alongside the
repeat period button. I also set it so it always creates the custom
recurrence dialog from populateFromEdit, which allows it to store
the current custom values in that dialog; the recurrence values are
then accessible on a populateForSave call.
Also, added periods as suggested to the custom recurrent text: on
the end of the custom rules, and the end date. Start date is on
another line.
https://bugzilla.zimbra.com/show_bug.cgi?id=99179
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/model/ZmRecurrence.js#3 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/view/ZmCalItemEditView.js#7 edit
... //depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#47 edit |
Change 544301 by vbellows@vbellows-main on 2015/05/11 12:22:36
Bug: 99179 - Modify recurring appointment - custom repeat shows
incorrect values
The appt edit view is initialized from the appt (populateForEdit),
then saves back into the appt (populateForSave), but with
potentially incomplete information. Note, populateForSave is called
whenever the code needs the appointment to reflect the entries in
the appt edit view - upon an actual save, or when it pops up a
subdialog, such as the custom recurrence dialog.
I've modified it such that ZmCalItemEditView presents the 'Custom'
choice in the repeat dropdown when there is a custom recurrence
(which makes its consistent with what happens when you first create
a custom recurrence). Previously it would show the recurrence
period in the drop down (Daily, Weekly, etc), but not the fact that
it is custom - that was indicated only by the blurb alongside the
repeat period button. I also set it so it always creates the custom
recurrence dialog from populateFromEdit, which allows it to store
the current custom values in that dialog; the recurrence values are
then accessible on a populateForSave call.
Also, added periods as suggested to the custom recurrent text: on
the end of the custom rules, and the end date. Start date is on
another line.
Merging
//depot/zimbra/JUDASPRIEST/ZimbraWebClient/WebRoot/...
to //depot/zimbra/main/ZimbraWebClient/WebRoot/...
https://bugzilla.zimbra.com/show_bug.cgi?id=99179
Affected files ...
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/model/ZmRecurrence.js#37 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/js/zimbraMail/calendar/view/ZmCalItemEditView.js#177 integrate
... //depot/zimbra/main/ZimbraWebClient/WebRoot/messages/ZmMsg.properties#1167 integrate |
Bug 99443 | Patch Release Notes: include all node types where patch should be installed |
Bug 99594 | Accessing message via EWS strips out MIME image data |
Change 545486 by rdesai@rdesai_macbook_z on 2015/05/25 22:53:33
Bug: 99594
Accessing message via EWS strips out MIME image data
Fixed the EWS code that determines whether a message has inline mime
part
Tested by using the sample message provided with the Bug
Verified by sending messages with attachment from Native
Mac/Outlook/ZWC and viewing in Native Mac/Outlook/ZWC
https://bugzilla.zimbra.com/show_bug.cgi?id=99594
Affected files ...
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/ews/util/EmailUtils.java#28 edit |
Change 545487 by rdesai@rdesai_macbook_z on 2015/05/25 22:55:12
Merging from main
Bug: 99594
Accessing message via EWS strips out MIME image data
Fixed the EWS code that determines whether a message has inline mime
part
Tested by using the sample message provided with the Bug
Verified by sending messages with attachment from Native
Mac/Outlook/ZWC and viewing in Native Mac/Outlook/ZWC
https://bugzilla.zimbra.com/show_bug.cgi?id=99594
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/ews/util/EmailUtils.java#6 integrate |
Change 545767 by rdesai@rdesai_macbook_z on 2015/05/28 07:21:09
Bug: 99594
Accessing message via EWS strips out MIME image data
Fixed wherein text below inline images was being stripped.
Also verify Bug 92491
https://bugzilla.zimbra.com/show_bug.cgi?id=99594
Affected files ...
... //depot/zimbra/main/ZimbraEws/src/java/com/zimbra/ews/util/EmailUtils.java#29 edit |
Change 545768 by rdesai@rdesai_macbook_z on 2015/05/28 07:23:35
Merging from main
Bug: 99594
Accessing message via EWS strips out MIME image data
Fixed wherein text below inline images was being stripped.
Also verify Bug 92491
https://bugzilla.zimbra.com/show_bug.cgi?id=99594
Affected files ...
... //depot/zimbra/JUDASPRIEST/ZimbraEws/src/java/com/zimbra/ews/util/EmailUtils.java#7 edit |
